On 12-03-26 10:55 AM, Sergei Shtylyov wrote:
> On 03/26/2012 05:38 PM, Paul Gortmaker wrote:
>>> I hate to add in more #ifdef CONFIG_PCI but there are already
>>> quite a few in this driver, and it seems like it hasn't been
>>> built with CONFIG_PCI set to off in quite some time.
>> Actually, please scrap this patch. The uglyness of more ifdefs
>> made me look at it again. It should be do-able in a cleaner way
>> with stubs, and it appears this may even be similar to an old fail
>> from the past:
> Also, see this patch:
> The driver patch this was done for is still in the -mm tree after all
>> I'll dig into it some more and follow up.
> I thought I addressed all issues with compilation of this driver with
> CONFIG_PCI=n. Apparently not, and some seem to have accumulated over time...
I got sidetracked working on other things, but I did manage to
learn this so far - It turns out that Randy fixed it and then
James un-fixed it in this commit:
Author: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: Mon Jan 30 10:40:47 2012 -0600
[PARISC] fix compile break caused by iomap: make IOPORT/PCI mapping
Reverting the above and mips builds 3c59x just fine. Note that MIPS
allmodconfig does not have either CONFIG_GENERIC_IOMAP or the other
> WBR, Sergei