linux-mips
[Top] [All Lists]

Re: [PATCH] netdev: fix compile issues for !CONFIG_PCI in 3c59x

To: Paul Gortmaker <paul.gortmaker@gmail.com>
Subject: Re: [PATCH] netdev: fix compile issues for !CONFIG_PCI in 3c59x
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Mon, 26 Mar 2012 18:55:10 +0400
Cc: klassert@mathematik.tu-chemnitz.de, netdev@vger.kernel.org, linux-mips@linux-mips.org, Paul Gortmaker <paul.gortmaker@windriver.com>
In-reply-to: <CAP=VYLpOJOueFfzxFGCu5cKQ9--F8CqC5JWjBxej7u=8z3K0xQ@mail.gmail.com>
References: <1332724306-8799-1-git-send-email-paul.gortmaker@windriver.com> <CAP=VYLpOJOueFfzxFGCu5cKQ9--F8CqC5JWjBxej7u=8z3K0xQ@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120312 Thunderbird/11.0
Hello.

On 03/26/2012 05:38 PM, Paul Gortmaker wrote:

I hate to add in more #ifdef CONFIG_PCI but there are already
quite a few in this driver, and it seems like it hasn't been
built with CONFIG_PCI set to off in quite some time.

Actually, please scrap this patch.  The uglyness of more ifdefs
made me look at it again.  It should be do-able in a cleaner way
with stubs, and it appears this may even be similar to an old fail
from the past:

http://lkml.indiana.edu/hypermail/linux/kernel/1107.3/00109.html

   Also, see this patch:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0da0ead90122578ef6e4afba9ba4bcd3455fd8e8

The driver patch this was done for is still in the -mm tree after all these years.:-)

I'll dig into it some more and follow up.

I thought I addressed all issues with compilation of this driver with CONFIG_PCI=n. Apparently not, and some seem to have accumulated over time...

Thanks,
Paul.

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>