linux-mips
[Top] [All Lists]

Re: [PATCH 1/6] MIPS: Loongson32: Remove unused platform devices

To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH 1/6] MIPS: Loongson32: Remove unused platform devices
From: Paul Burton <paul.burton@mips.com>
Date: Wed, 23 Jan 2019 21:40:31 +0000
Accept-language: en-US
Authentication-results: spf=none (sender IP is ) smtp.mailfrom=pburton@wavecomp.com;
Cc: Kelvin Cheung <keguang.zhang@gmail.com>, "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>, Paul Burton <pburton@wavecomp.com>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wavesemi.onmicrosoft.com; s=selector1-wavecomp-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BjY1WzdfdNUoQ+pfa7ZJ4VgnZ2tMLfDMiwlUXaLYPgg=; b=GLXzwhG5VRFu1aq+PrEx1TgrLzdqLyVW21Uaw1dzOSFVG+rH/9Zv0HJHapBCXqGCsn8YE3h/r9n75ossylAOX9iNBPv4DFso3Bf9u3/N4VRRHdRi4SOAtCzUfPx72KDrmHpIuKf5OmpIeg52dhDNQZS3GxmMFM5+5tJRAgVm5iA=
In-reply-to: <32183566-60A0-4652-8B75-2CDA04208EF9@flygoat.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20190122130415.3440-1-jiaxun.yang@flygoat.com> <CY4PR2201MB12723EF92091D72E29C5B2A6C1990@CY4PR2201MB1272.namprd22.prod.outlook.com> <CAJhJPsU1DPBp6it0agNrDfLpQGRV0c45mH6mTi=wcwt0OZikkQ@mail.gmail.com> <32183566-60A0-4652-8B75-2CDA04208EF9@flygoat.com>
Sender: linux-mips-bounce@linux-mips.org
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99
Thread-index: AQHUslMkvVtYRodDHUajofYGd9LUmaW8EuYAgAAfLYCAAAP3AIABLdAA
Thread-topic: [PATCH 1/6] MIPS: Loongson32: Remove unused platform devices
User-agent: NeoMutt/20180716
Hi Jiaxun & Kevin,

On Wed, Jan 23, 2019 at 11:40:12AM +0800, Jiaxun Yang wrote:
> On January 23, 2019 11:26:01 AM GMT+08:00, Kelvin Cheung 
> <keguang.zhang@gmail.com> wrote:
> >Hi Paul, Jiaxun,
> >The platform.[ch] is the common code for both Loongson1B and
> >Loongson1C.
> >And the DMA and NAND device are used by Loongson1B.
> 
> Hi Kevin:
> It seemed like there are no drivers for these devices in mainline kernel.
> It would be nice if you can submit these driver before revert this patch.

I agree with Jiaxun here - if you want the platform code to be part of
mainline then the driver needs to be too. Conversely if you have drivers
that are not part of the mainline kernel then maintaining the platform
code to go with them should be a negligible amount of extra work.

> BTW: I'm currently working on refactor Loongson32 platform with DeviceTree.

Neat - I look forward to seeing that :)

Thanks,
    Paul

<Prev in Thread] Current Thread [Next in Thread>