linux-mips
[Top] [All Lists]

Re: [PATCH v3 6/8] socket: Add SO_TIMESTAMP[NS]_NEW

To: Deepa Dinamani <deepa.kernel@gmail.com>
Subject: Re: [PATCH v3 6/8] socket: Add SO_TIMESTAMP[NS]_NEW
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Tue, 8 Jan 2019 09:03:04 -0500
Cc: David Miller <davem@davemloft.net>, LKML <linux-kernel@vger.kernel.org>, Network Development <netdev@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>, y2038 Mailman List <y2038@lists.linaro.org>, "James E.J. Bottomley" <jejb@parisc-linux.org>, Ralf Baechle <ralf@linux-mips.org>, rth@twiddle.net, linux-alpha@vger.kernel.org, "open list:RALINK MIPS ARCHITECTURE" <linux-mips@linux-mips.org>, Parisc List <linux-parisc@vger.kernel.org>, linux-rdma@vger.kernel.org, sparclinux <sparclinux@vger.kernel.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2u1e3R9FKHkYT4sG/wFzD0rdqI12hDyfz5KaMxjR9iM=; b=mcbxLlYku3eSZzrS/PjlTJ61jmlRNiW3xrwNwVihU0gjdoTaCxClHPWdPw06gGNCst pgiUoNjbMhcqYifr0k1Q7EDqZZyEJHnH5ftiIWC8OwymLkxpWEblgvN+zwwnQcr60IgD uJ0zvHlCpfXHyxppAOGFysgq2mlrcUYF+RnLeXvfb2Tui4pAFQtEng7gFFwIf1ZBoovJ /z09MSZZUKdR4QZHmyDIJL8Aitsf0Tyk0Rf+zsu7vfhxpNC2Ywvj4EsCxRJxJ1N1wDy3 ErupAlDDHue0uvy7bCVWuLyfuCwOMH/FfEkf2hC28eY73vrqao9OQmBoDHt46CQ//U/U 7ecA==
In-reply-to: <20190108032657.8331-7-deepa.kernel@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20190108032657.8331-1-deepa.kernel@gmail.com> <20190108032657.8331-7-deepa.kernel@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Mon, Jan 7, 2019 at 10:29 PM Deepa Dinamani <deepa.kernel@gmail.com> wrote:
>
> Add SO_TIMESTAMP_NEW and SO_TIMESTAMPNS_NEW variants of
> socket timestamp options.
> These are the y2038 safe versions of the SO_TIMESTAMP_OLD
> and SO_TIMESTAMPNS_OLD for all architectures.
>
> Note that the format of scm_timestamping.ts[0] is not changed
> in this patch.
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> Cc: jejb@parisc-linux.org
> Cc: ralf@linux-mips.org
> Cc: rth@twiddle.net
> Cc: linux-alpha@vger.kernel.org
> Cc: linux-mips@linux-mips.org
> Cc: linux-parisc@vger.kernel.org
> Cc: linux-rdma@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: sparclinux@vger.kernel.org

> @@ -1864,20 +1864,39 @@ static void tcp_update_recv_tstamps(struct sk_buff 
> *skb,
>  static void tcp_recv_timestamp(struct msghdr *msg, const struct sock *sk,
>                                struct scm_timestamping *tss)
>  {
> -       struct __kernel_old_timeval tv;
>         bool has_timestamping = false;
> +       int new_tstamp = sock_flag(sk, SOCK_TSTAMP_NEW);

nit: move above has_timestamping to maintain reverse christmas tree ordering

<Prev in Thread] Current Thread [Next in Thread>