linux-mips
[Top] [All Lists]

Re: [PATCH mips-fixes] MIPS: BCM47XX: Setup struct device for the SoC

To: Rafał Miłecki <zajec5@gmail.com>
Subject: Re: [PATCH mips-fixes] MIPS: BCM47XX: Setup struct device for the SoC
From: kbuild test robot <lkp@intel.com>
Date: Mon, 7 Jan 2019 06:32:48 +0800
Cc: kbuild-all@01.org, Paul Burton <paul.burton@mips.com>, Ralf Baechle <ralf@linux-mips.org>, James Hogan <jhogan@kernel.org>, Christoph Hellwig <hch@lst.de>, Linus Walleij <linus.walleij@linaro.org>, Hauke Mehrtens <hauke@hauke-m.de>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, Rafał Miłecki <rafal@milecki.pl>
In-reply-to: <20190102125147.3282-1-zajec5@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20190102125147.3282-1-zajec5@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.23 (2014-03-12)
Hi Rafał,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.20 next-20190103]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/MIPS-BCM47XX-Setup-struct-device-for-the-SoC/20190102-210611
config: mips-bcm47xx_defconfig (attached as .config)
compiler: mipsel-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=mips 

All errors (new ones prefixed by >>):

   arch/mips/bcm47xx/setup.c: In function 'bcm47xx_register_bus_complete':
>> arch/mips/bcm47xx/setup.c:267:3: error: ignoring return value of 
>> 'device_register', declared with attribute warn_unused_result 
>> [-Werror=unused-result]
      device_register(bcm47xx_bus.bcma.dev);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +/device_register +267 arch/mips/bcm47xx/setup.c

   256  
   257  static int __init bcm47xx_register_bus_complete(void)
   258  {
   259          switch (bcm47xx_bus_type) {
   260  #ifdef CONFIG_BCM47XX_SSB
   261          case BCM47XX_BUS_TYPE_SSB:
   262                  /* Nothing to do */
   263                  break;
   264  #endif
   265  #ifdef CONFIG_BCM47XX_BCMA
   266          case BCM47XX_BUS_TYPE_BCMA:
 > 267                  device_register(bcm47xx_bus.bcma.dev);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

<Prev in Thread] Current Thread [Next in Thread>