linux-mips
[Top] [All Lists]

Re: [PATCH v2] SUNRPC: Fix TCP receive code on archs with flush_dcache_p

To: "geert@linux-m68k.org" <geert@linux-m68k.org>
Subject: Re: [PATCH v2] SUNRPC: Fix TCP receive code on archs with flush_dcache_page()
From: Trond Myklebust <trondmy@hammerspace.com>
Date: Thu, 3 Jan 2019 14:26:37 +0000
Accept-language: en-US, en-GB
Authentication-results: spf=none (sender IP is ) smtp.mailfrom=trondmy@hammerspace.com;
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hammerspace.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CPBdjZMSM0cjlOSbKY6UEb8ZeEgeTeHV0i/b4QKb9YI=; b=BnKCj01ahiMWzfHdr/eDKsRKMGeahe+/Esd8cXBCWz3mDvS4gwDenOSDYJpB3O00CS8EECRYTjOTJGgt/47BwcPRSakPKpZeAuWJLcENbZGgqoNW79Q4bWWC8cCUegMZKy/zFhlfQ3Pm9+XUAWT/pNkJg20TkPfrm/gNLo56D5U=
In-reply-to: <3f4ee085ffde4c9823719e6607f521836c4158cf.camel@hammerspace.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20190103061324.16607-1-trond.myklebust@hammerspace.com> <CAMuHMdXpHLjJBMQWDaWKYQFfY4_3yVi9NdBYnWr6Xfzttrb5iA@mail.gmail.com> <3f4ee085ffde4c9823719e6607f521836c4158cf.camel@hammerspace.com>
Sender: linux-mips-bounce@linux-mips.org
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99
Thread-index: AQHUoyua7l5ZKHM4hESBaVcRAYnWxaWdVHGAgABAooCAAAU+gA==
Thread-topic: [PATCH v2] SUNRPC: Fix TCP receive code on archs with flush_dcache_page()
On Thu, 2019-01-03 at 14:07 +0000, Trond Myklebust wrote:
> On Thu, 2019-01-03 at 11:16 +0100, Geert Uytterhoeven wrote:
> > 
> > I don't understand the code well enough to see why the call to
> > xs_flush_bvec() is needed in this branch only, but it does fix TCP
> > NFS on RBTX4927, so
> > Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>

Sorry. I forgot to answer the implicit question there. This is the only
place where we may find ourselves reading directly from a socket into
the page cache, so that's why we don't need xs_flush_bvec() in the
other branches. The kvec entries in struct xdr_buf should always point
to private memory buffers that can't be mapped into user space.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com


<Prev in Thread] Current Thread [Next in Thread>