[Top] [All Lists]

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

To: Mikko Perttunen <>,,,,
Subject: Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long
From: Bryan O'Donoghue <>
Date: Sun, 31 Dec 2017 13:40:07 +0000
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=owfd/YVR/EzDiMXyNdt2qlnnnm75UX6BTgVMALTYcGc=; b=jKae8n48cRp4UDuCUX/DPv9YXEEwtkhcYFDJQeAFf7+zUL5/W1N6gS19IzVVIDDF3K GZWKHf96rTHVF5TZ1NZ/lpxoLZaOE599fET1erdywYTlqnSlsXMLf5TDXywGtpAUIrSl w2pJLmtVGAQ+XgFMjXS14c7+Qdqz/7isM9slzVuDO1iHMxYMnzwd4X3FSUYz/xl54pqE VqxYB3b1h0jb+tYL+IGuPXxQxp4vrLvpgHsNUvDr4h7YsSWLjZZv4y62T7hpf+t0a2nJ rSPyiDAHh6pBBN+DFuyLXJqZXnOK0RwDaph9dO7F/Xq/eHhrsrR4R2GgZmIDmU19ACtq 5raA==
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <> <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1
On 30/12/17 16:36, Mikko Perttunen wrote:
FWIW, we had this problem some years ago with the Tegra CPU clock - then it was determined that a simpler solution was to have the determine_rate callback support unsigned long rates - so clock drivers that need to return rates higher than 2^31 can instead implement the determine_rate callback. That is what's currently implemented.


Granted we could work around it but, having both zero and less than zero indicate error means you can't support larger than LONG_MAX which is I think worth fixing.


<Prev in Thread] Current Thread [Next in Thread>