linux-mips
[Top] [All Lists]

Re: [PATCH v2 4/8] watchdog: JZ4740: Drop module remove function

To: Paul Cercueil <paul@crapouillou.net>, Ralf Baechle <ralf@linux-mips.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [PATCH v2 4/8] watchdog: JZ4740: Drop module remove function
From: Guenter Roeck <linux@roeck-us.net>
Date: Sat, 30 Dec 2017 08:08:30 -0800
Cc: devicetree@vger.kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=npNpL8HDVupXoTAcn9uEeOgCz156pfXEYir3frQssHk=; b=AIQEu7e7exeHH4aOPA9yTOungQVhBlpeyt42qFKaSSy/1n96maj9A/XQX4Cs996w+m 96PP0T+k6imHPFQf8uu+jxGxZ0KLEpPgweCozwVmUPJJjPEY/dJ3kE2gekhMe4GACW1+ AOBGzHHR+GjuTw/BhQsb+EQNPUDjGqMjpF/Bd64ACG3opcBOQ6DXrz79OpqoQBYaGH2q uBUPMGMTrDN1KN4asrOg87HOUakBU1JF+MNsDMIhfEX78tqZYRXAeldNhk1A+uYWyXo7 9kM3tMTLW1ib8Nnt2q+mif9VFmz/6qkVw9Pw5rSmP1SIk/skqFe9V3rGQJfP7jNU5xa3 lY8A==
In-reply-to: <20171230135108.6834-4-paul@crapouillou.net>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20171228162939.3928-2-paul@crapouillou.net> <20171230135108.6834-1-paul@crapouillou.net> <20171230135108.6834-4-paul@crapouillou.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
On 12/30/2017 05:51 AM, Paul Cercueil wrote:
When the watchdog was configured for nowayout, and after the
userspace watchdog daemon closed the dev node without sending the
magic character, unloading this module stopped the watchdog
hardware, which was clearly a problem.

Besides, unloading the module is not possible when the userspace
watchdog daemon is running, so it's safe to assume that we don't
need to stop the watchdog hardware in the jz4740_wdt_remove()
function.

For this reason, the jz4740_wdt_remove() function can then be
dropped alltogether.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

---
  drivers/watchdog/jz4740_wdt.c | 8 --------
  1 file changed, 8 deletions(-)

  v2: New patch in this series

diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
index fa7f49a3212c..02b9b8e946a2 100644
--- a/drivers/watchdog/jz4740_wdt.c
+++ b/drivers/watchdog/jz4740_wdt.c
@@ -205,16 +205,8 @@ static int jz4740_wdt_probe(struct platform_device *pdev)
        return 0;
  }
-static int jz4740_wdt_remove(struct platform_device *pdev)
-{
-       struct jz4740_wdt_drvdata *drvdata = platform_get_drvdata(pdev);
-
-       return jz4740_wdt_stop(&drvdata->wdt);
-}
-
  static struct platform_driver jz4740_wdt_driver = {
        .probe = jz4740_wdt_probe,
-       .remove = jz4740_wdt_remove,
        .driver = {
                .name = "jz4740-wdt",
                .of_match_table = of_match_ptr(jz4740_wdt_of_matches),



<Prev in Thread] Current Thread [Next in Thread>