To: | Ralf Baechle <ralf@linux-mips.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Wim Van Sebroeck <wim@iguana.be>, Guenter Roeck <linux@roeck-us.net> |
---|---|
Subject: | [PATCH v2 1/8] watchdog: JZ4740: Disable clock after stopping counter |
From: | Paul Cercueil <paul@crapouillou.net> |
Date: | Sat, 30 Dec 2017 14:51:01 +0100 |
Cc: | devicetree@vger.kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, Paul Cercueil <paul@crapouillou.net> |
Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1514641890; bh=DfNLGtgkVAdoBDPJaV/O/b71c+4GokNl7f9avjKmWLw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=UazRKEfPsr1nlFJTTBC9LEVaMOue+gsltBRG+PQrlDFEJkg6QB2MOL+3Tl5ePpsSEIlHYu8hDUR3OhIKGKPTW1mpDnONN7QZ0GQlpDLPYK0NzMIBc87CZaGgNKiK6JSQFnLkDJ6vcAcSPqgmkIg7lWBzqyr4GWQWaYFwL8+fnc4= |
In-reply-to: | <20171228162939.3928-2-paul@crapouillou.net> |
List-archive: | <http://www.linux-mips.org/archives/linux-mips/> |
List-help: | <mailto:ecartis@linux-mips.org?Subject=help> |
List-id: | linux-mips <linux-mips.eddie.linux-mips.org> |
List-owner: | <mailto:ralf@linux-mips.org> |
List-post: | <mailto:linux-mips@linux-mips.org> |
List-software: | Ecartis version 1.0.0 |
List-subscribe: | <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips> |
List-unsubscribe: | <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips> |
Original-recipient: | rfc822;linux-mips@linux-mips.org |
References: | <20171228162939.3928-2-paul@crapouillou.net> |
Sender: | linux-mips-bounce@linux-mips.org |
Previously, the clock was disabled first, which makes the watchdog component insensitive to register writes. Signed-off-by: Paul Cercueil <paul@crapouillou.net> Reviewed-by: Guenter Roeck <linux@roeck-us.net> --- drivers/watchdog/jz4740_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) v2: No change diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c index 20627f22baf6..6955deb100ef 100644 --- a/drivers/watchdog/jz4740_wdt.c +++ b/drivers/watchdog/jz4740_wdt.c @@ -124,8 +124,8 @@ static int jz4740_wdt_stop(struct watchdog_device *wdt_dev) { struct jz4740_wdt_drvdata *drvdata = watchdog_get_drvdata(wdt_dev); - jz4740_timer_disable_watchdog(); writeb(0x0, drvdata->base + JZ_REG_WDT_COUNTER_ENABLE); + jz4740_timer_disable_watchdog(); return 0; } -- 2.11.0 |
Previous by Date: | [PATCH v2 2/8] watchdog: jz4740: Use devm_* functions, Paul Cercueil |
---|---|
Next by Date: | [PATCH v2 3/8] watchdog: JZ4740: Register a restart handler, Paul Cercueil |
Previous by Thread: | Re: [PATCH 1/7] watchdog: JZ4740: Disable clock after stopping counter, Guenter Roeck |
Next by Thread: | [PATCH v2 2/8] watchdog: jz4740: Use devm_* functions, Paul Cercueil |
Indexes: | [Date] [Thread] [Top] [All Lists] |