To: | Ralf Baechle <ralf@linux-mips.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Wim Van Sebroeck <wim@iguana.be>, Guenter Roeck <linux@roeck-us.net> |
---|---|
Subject: | [PATCH v2 2/8] watchdog: jz4740: Use devm_* functions |
From: | Paul Cercueil <paul@crapouillou.net> |
Date: | Sat, 30 Dec 2017 14:51:02 +0100 |
Cc: | devicetree@vger.kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, Paul Cercueil <paul@crapouillou.net> |
Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1514641891; bh=gPm3Cy8HDg2aGN25PrFTosZKWHDtubTfrMqAjwiGdhs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=cPMzwOCBZkrCAP5BpqbmdNbuVXtaoCfIXkOqG/C4d6MC5FGrmG+YT3XB0AZMzkvWhiyRKSg+KSaxbIlFZkeWVMxnopQgdPlb72/AaYhVL4p+2L83pYwFyuqTdeN8biMuDl+kz1eimvP2aAyRK0nKDlWKD92hIHuT3c71AtBkRck= |
In-reply-to: | <20171230135108.6834-1-paul@crapouillou.net> |
List-archive: | <http://www.linux-mips.org/archives/linux-mips/> |
List-help: | <mailto:ecartis@linux-mips.org?Subject=help> |
List-id: | linux-mips <linux-mips.eddie.linux-mips.org> |
List-owner: | <mailto:ralf@linux-mips.org> |
List-post: | <mailto:linux-mips@linux-mips.org> |
List-software: | Ecartis version 1.0.0 |
List-subscribe: | <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips> |
List-unsubscribe: | <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips> |
Original-recipient: | rfc822;linux-mips@linux-mips.org |
References: | <20171228162939.3928-2-paul@crapouillou.net> <20171230135108.6834-1-paul@crapouillou.net> |
Sender: | linux-mips-bounce@linux-mips.org |
- Use devm_clk_get instead of clk_get - Use devm_watchdog_register_device instead of watchdog_register_device Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- drivers/watchdog/jz4740_wdt.c | 27 ++++++++------------------- 1 file changed, 8 insertions(+), 19 deletions(-) v2: No change diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c index 6955deb100ef..92d6ca8ceb49 100644 --- a/drivers/watchdog/jz4740_wdt.c +++ b/drivers/watchdog/jz4740_wdt.c @@ -178,40 +178,29 @@ static int jz4740_wdt_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); drvdata->base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(drvdata->base)) { - ret = PTR_ERR(drvdata->base); - goto err_out; - } + if (IS_ERR(drvdata->base)) + return PTR_ERR(drvdata->base); - drvdata->rtc_clk = clk_get(&pdev->dev, "rtc"); + drvdata->rtc_clk = devm_clk_get(&pdev->dev, "rtc"); if (IS_ERR(drvdata->rtc_clk)) { dev_err(&pdev->dev, "cannot find RTC clock\n"); - ret = PTR_ERR(drvdata->rtc_clk); - goto err_out; + return PTR_ERR(drvdata->rtc_clk); } - ret = watchdog_register_device(&drvdata->wdt); + ret = devm_watchdog_register_device(&pdev->dev, &drvdata->wdt); if (ret < 0) - goto err_disable_clk; + return ret; platform_set_drvdata(pdev, drvdata); - return 0; -err_disable_clk: - clk_put(drvdata->rtc_clk); -err_out: - return ret; + return 0; } static int jz4740_wdt_remove(struct platform_device *pdev) { struct jz4740_wdt_drvdata *drvdata = platform_get_drvdata(pdev); - jz4740_wdt_stop(&drvdata->wdt); - watchdog_unregister_device(&drvdata->wdt); - clk_put(drvdata->rtc_clk); - - return 0; + return jz4740_wdt_stop(&drvdata->wdt); } static struct platform_driver jz4740_wdt_driver = { -- 2.11.0 |
Previous by Date: | Re: consolidate direct dma mapping and swiotlb support, Christoph Hellwig |
---|---|
Next by Date: | [PATCH v2 1/8] watchdog: JZ4740: Disable clock after stopping counter, Paul Cercueil |
Previous by Thread: | [PATCH v2 1/8] watchdog: JZ4740: Disable clock after stopping counter, Paul Cercueil |
Next by Thread: | Re: [PATCH v2 2/8] watchdog: jz4740: Use devm_* functions, Guenter Roeck |
Indexes: | [Date] [Thread] [Top] [All Lists] |