linux-mips
[Top] [All Lists]

Re: [PATCH 1/7] MIPS: Loongson64: cleanup all cs5536 files to use SPDX I

To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH 1/7] MIPS: Loongson64: cleanup all cs5536 files to use SPDX Identifier
From: Philippe Ombredanne <pombredanne@nexb.com>
Date: Fri, 29 Dec 2017 13:40:26 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, James Hogan <james.hogan@mips.com>, Huacai CHen <chenhc@lemote.com>, Linux MIPS <linux-mips@linux-mips.org>, LKML <linux-kernel@vger.kernel.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nI1/fjh57qUyMUAwFf+EZ5+NXWqW8CeIwINXitgtjlI=; b=rAtwXcRAlIthWOQLZ4ajP2Y0Ve09bunssiPt38jkeUu4hLXHk2z0sEUYyIhxQRaz1h o7LvX4SPhmoPsqoA2TeitS9UgZLz8iWGgwO3fz5rI4tguZbUS7hC7Niru9EgFWbJv5Ix iVOTSFMtdbmZVtUDx1kyFT4KY89x2tTJP1asJmkqKLnt5MqQ1slZftMl4dm+VWDqWUOX Ltx1KtftvQ6BYwMcGqNV5TzrQg1Se+FzY1Cu9HO0jkti+nUE03qPZOu/u7XRNnFfTAaF C7BkNYdEgobU4qwqer79Qu2RUFpYbHx5yLAElzYkcfUIKJ6Ek0bXaUTQ7lyxHVpVH9Lm dqew==
In-reply-to: <20171226132339.7356-2-jiaxun.yang@flygoat.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20171226132339.7356-1-jiaxun.yang@flygoat.com> <20171226132339.7356-2-jiaxun.yang@flygoat.com>
Sender: linux-mips-bounce@linux-mips.org
On Tue, Dec 26, 2017 at 2:23 PM, Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> To reduce unnecessary license text.

<snip>

> diff --git a/arch/mips/loongson64/common/cs5536/cs5536_acc.c 
> b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> index ab4d6cc57384..ba0474bb4a3d 100644
> --- a/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> +++ b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

Please use  // comment in .c files as requested by Linus and discussed on list.
This is also documented in Thomas doc patches.
This applies to the whole patch set.

<snip>

> diff --git a/arch/mips/loongson64/common/cs5536/cs5536_isa.c 
> b/arch/mips/loongson64/common/cs5536/cs5536_isa.c
> index 924be39e7733..c358c0755eff 100644
> --- a/arch/mips/loongson64/common/cs5536/cs5536_isa.c
> +++ b/arch/mips/loongson64/common/cs5536/cs5536_isa.c
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

And this is the correct comment style for .h files.

Thanks!

-- 
Cordially
Philippe Ombredanne

<Prev in Thread] Current Thread [Next in Thread>