linux-mips
[Top] [All Lists]

[PATCH 21/67] dma-mapping: warn when there is no coherent_dma_mask

To: iommu@lists.linux-foundation.org
Subject: [PATCH 21/67] dma-mapping: warn when there is no coherent_dma_mask
From: Christoph Hellwig <hch@lst.de>
Date: Fri, 29 Dec 2017 09:18:25 +0100
Cc: linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, adi-buildroot-devel@lists.sourceforge.net, linux-c6x-dev@linux-c6x.org, linux-cris-kernel@axis.com, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-metag@vger.kernel.org, Michal Simek <monstr@monstr.eu>, linux-mips@linux-mips.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, patches@groups.riscv.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, Guan Xuetao <gxt@mprc.pku.edu.cn>, x86@kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=eg3FoMyX47+08LQfB+VADoF49XFCp9/mxmidhro7i7k=; b=d7qtnqlhDxSs/fjn4TyeuLNbB JZKYBXfjjhVEMqln+n4jo8XnWltIbS8+q/R3R9oKx+fo0VG/A1GrT6wMh5JRQSBLEy3q3xjwc4GBs CPBI1QFxVlTomTOW37gi0ShCOFh+5Gf+Rav93VIAyWL8Jszzbkjr5OToT67QwfhTKtYwgG1gMnI4H kwrh4+TD1blW+IjqabKMdRgE/Wxf7a3vWRad5hiZMnQrEWGovBVnUQY6ttvHpjGwh3P83kgG/RD8N HFX62BzWk+pLLtbkacZAGwsB75DB2iZ5Rup6e/s+mMYXS6CCtZDYByrwlcnO7nMgNeLd6XjN7R0G3 bvb4pEXww==;
In-reply-to: <20171229081911.2802-1-hch@lst.de>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20171229081911.2802-1-hch@lst.de>
Sender: linux-mips-bounce@linux-mips.org
These days all devices should have a DMA coherent mask, and most dma_ops
implementations rely on that fact.  But just to be sure add an assert to
ring the warning bell if that is not the case.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 include/linux/dma-mapping.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index e77e2dec4723..2779d544485c 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -520,6 +520,7 @@ static inline void *dma_alloc_attrs(struct device *dev, 
size_t size,
        void *cpu_addr;
 
        BUG_ON(!ops);
+       WARN_ON_ONCE(!dev->coherent_dma_mask);
 
        if (dma_alloc_from_dev_coherent(dev, size, dma_handle, &cpu_addr))
                return cpu_addr;
-- 
2.14.2


<Prev in Thread] Current Thread [Next in Thread>