linux-mips
[Top] [All Lists]

[PATCH v4 08/15] MIPS: ingenic: Use common cmdline handling code

To: Ralf Baechle <ralf@linux-mips.org>, Rob Herring <robh+dt@kernel.org>, Michael Turquette <mturquette@baylibre.com>
Subject: [PATCH v4 08/15] MIPS: ingenic: Use common cmdline handling code
From: Paul Cercueil <paul@crapouillou.net>
Date: Thu, 28 Dec 2017 14:56:27 +0100
Cc: Mark Rutland <mark.rutland@arm.com>, Stephen Boyd <sboyd@codeaurora.org>, Maarten ter Huurne <maarten@treewalker.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-clk@vger.kernel.org, Paul Burton <paul.burton@imgtec.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1514469417; bh=Q/M6rAjjgQUZ3iqnQqDtw+goiQ11NGhNqO72BhMVqzQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=jIPsmJpIY3cfWVGVwVFr6bk6t1nh53R3bUl7x3yXBkUr/GG4IQLdhvskZSmoSdzkdZYEuqMSCxqAyBx6eDZf3AS8LbhWFX385h3eDlFm/2+VvA1Yd2FpbwXaubn3rbxpWL8WEQeuCqNOJpsuzKB8d2mwaknyRR0bcBQ3sOywTr8=
In-reply-to: <20171228135634.30000-1-paul@crapouillou.net>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20170702163016.6714-2-paul@crapouillou.net> <20171228135634.30000-1-paul@crapouillou.net>
Sender: linux-mips-bounce@linux-mips.org
From: Paul Burton <paul.burton@imgtec.com>

jz4740_init_cmdline appends all arguments from argv (in fw_arg1) to
arcs_cmdline, up to argc (in fw_arg0). The common code in
fw_init_cmdline will do the exact same thing when run on a system where
fw_arg0 isn't a pointer to kseg0 (it'll also set _fw_envp but we don't
use it). Remove the custom implementation & use the generic code.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
---
 arch/mips/jz4740/prom.c | 24 ++----------------------
 1 file changed, 2 insertions(+), 22 deletions(-)

 v2: No change
 v3: No change
 v4: No change

diff --git a/arch/mips/jz4740/prom.c b/arch/mips/jz4740/prom.c
index 47e857194ce6..a62dd8e6ecf9 100644
--- a/arch/mips/jz4740/prom.c
+++ b/arch/mips/jz4740/prom.c
@@ -20,33 +20,13 @@
 #include <linux/serial_reg.h>
 
 #include <asm/bootinfo.h>
+#include <asm/fw/fw.h>
 #include <asm/mach-jz4740/base.h>
 
-static __init void jz4740_init_cmdline(int argc, char *argv[])
-{
-       unsigned int count = COMMAND_LINE_SIZE - 1;
-       int i;
-       char *dst = &(arcs_cmdline[0]);
-       char *src;
-
-       for (i = 1; i < argc && count; ++i) {
-               src = argv[i];
-               while (*src && count) {
-                       *dst++ = *src++;
-                       --count;
-               }
-               *dst++ = ' ';
-       }
-       if (i > 1)
-               --dst;
-
-       *dst = 0;
-}
-
 void __init prom_init(void)
 {
-       jz4740_init_cmdline((int)fw_arg0, (char **)fw_arg1);
        mips_machtype = MACH_INGENIC_JZ4740;
+       fw_init_cmdline();
 }
 
 void __init prom_free_prom_memory(void)
-- 
2.11.0


<Prev in Thread] Current Thread [Next in Thread>