linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] MIPS: math-emu: Do not export function `srl128`

To: Aleksandar Markovic <Aleksandar.Markovic@mips.com>
Subject: Re: [PATCH 1/2] MIPS: math-emu: Do not export function `srl128`
From: Mathieu Malaterre <malat@debian.org>
Date: Wed, 27 Dec 2017 09:26:42 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, Miodrag Dinic <Miodrag.Dinic@mips.com>, Goran Ferenc <goran.ferenc@imgtec.com>, James Hogan <jhogan@kernel.org>, Douglas Leung <douglas.leung@imgtec.com>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=R5UWXg5qyBic0J6JQqwxYExnkxlP80adqG5fydbaIPk=; b=dejasInK6B/9Nyx8VJHCEvKIDAhwuw4bam9cmxlFqxhu/Fvz3Q0z0YKo0OzL7/Zs0W eXddpbGPFlMz/DaVT1FZKZ4lUejOotZXHIxBlcOFEPkMtPGPyF5Xo3ZvlXIUAlQRp5hZ qxly8oT0qJfR6rBI4tAt8ta+bpR8nJM/jT3bBPRszv5mOZt8CK02IdR2uyOGBD3E2/Jj QeDv0sAcS2kwnw7MGbr7QXJr/JGy9krz84u0OXXzitXdFROt8ht9bT2ltf8Jrb2hQbUh XIWvPJAVEpjQXFYQzqIr8SBSZhV+l3Br3eAjLBL9vsUrpqXPi0FPRtx/Fab0Eu6vdN0s oLVw==
In-reply-to: <BD3A5F1946F2E540A31AF2CE969BAEEEC28277@MIPSMAIL01.mipstec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20171226104554.19612-1-malat@debian.org> <BD3A5F1946F2E540A31AF2CE969BAEEEC2826A@MIPSMAIL01.mipstec.com> <BD3A5F1946F2E540A31AF2CE969BAEEEC28277@MIPSMAIL01.mipstec.com>
Sender: linux-mips-bounce@linux-mips.org
On Tue, Dec 26, 2017 at 7:10 PM, Aleksandar Markovic
<Aleksandar.Markovic@mips.com> wrote:
>> > Fix non-fatal warning:
>> >
>> > arch/mips/math-emu/dp_maddf.c:19:6: warning: no previous prototype for 
>> > ‘srl128’ [-Wmissing-prototypes]
>> >  void srl128(u64 *hptr, u64 *lptr, int count)
>> >
>> > Signed-off-by: Mathieu Malaterre <malat@debian.org>
>> > ---
>> >  arch/mips/math-emu/dp_maddf.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/arch/mips/math-emu/dp_maddf.c b/arch/mips/math-emu/dp_maddf.c
>> > index 7ad79ed411f5..0e2278a47f43 100644
>> > --- a/arch/mips/math-emu/dp_maddf.c
>> > +++ b/arch/mips/math-emu/dp_maddf.c
>> > @@ -16,7 +16,7 @@
>> >
>> >
>> >  /* 128 bits shift right logical with rounding. */
>> > -void srl128(u64 *hptr, u64 *lptr, int count)
>> > +static void srl128(u64 *hptr, u64 *lptr, int count)
>> >  {
>> >          u64 low;
>> >
>> > --
>> > 2.11.0
>>
>> Acked-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
>
> However, there is an already submitted patch: (the code change is identical)
>
> https://www.linux-mips.org/archives/linux-mips/2017-11/msg00044.html
>
> Status of that patch on patchwork is "Accepted".

Sorry did not realized you sent it already.

Thanks

<Prev in Thread] Current Thread [Next in Thread>