linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Use proper @return keyword

To: Mathieu Malaterre <malat@debian.org>
Subject: Re: [PATCH] MIPS: Use proper @return keyword
From: Randy Dunlap <rdunlap@infradead.org>
Date: Tue, 26 Dec 2017 08:29:16 -0800
Cc: Ralf Baechle <ralf@linux-mips.org>, "Maciej W. Rozycki" <macro@mips.com>, Paul Burton <paul.burton@mips.com>, Ingo Molnar <mingo@kernel.org>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=f1lm3HMyyklfEayuDgXXvu7I1nj2jPSCHx9Z/REaL6c=; b=sn7y3cxiQRqOt+g7rcv1dyvbw v5PP0a6XyHgaPOfkxAz5F4fwxraz7GQP4bhrVwt4i9gFmNJzg6cOtrBWEHh/g8Sj9XGTZalCKjIt5 su2uQniutPrHl80/oxhqhg0vCXcFizcJXU1MIh2GHNT3r1lDow9bTuRFO6CWiHWtS7txaLGJ2hLHU uO/1sXklF1TcvSL5tUZZPOosHZ7cF9+aYPBh2NwBg9PekdB1HeG9re7EYf4twon3pWmIoI+zSExQ3 jbnjv484jQOZetLT0npOj5jJLxA618ObLLeNCbN60UUMXQ9FvxZ6eihskIDED7RNS5Z2cZOoE/tdM XoSPNxOHg==;
In-reply-to: <20171226105532.23452-1-malat@debian.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20171226105532.23452-1-malat@debian.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2
On 12/26/2017 02:55 AM, Mathieu Malaterre wrote:
> Fix non-fatal warning:
> 
> arch/mips/kernel/branch.c:418: warning: Excess function parameter 'returns' 
> description in '__compute_return_epc_for_insn'
> 
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
>  arch/mips/kernel/branch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/kernel/branch.c b/arch/mips/kernel/branch.c
> index b79ed9af9886..e0d3a432e1e3 100644
> --- a/arch/mips/kernel/branch.c
> +++ b/arch/mips/kernel/branch.c
> @@ -399,7 +399,7 @@ int __MIPS16e_compute_return_epc(struct pt_regs *regs)
>   *
>   * @regs:    Pointer to pt_regs
>   * @insn:    branch instruction to decode
> - * @returns: -EFAULT on error and forces SIGILL, and on success
> + * @return:  -EFAULT on error and forces SIGILL, and on success

No @, just
        return: <text>

>   *           returns 0 or BRANCH_LIKELY_TAKEN as appropriate after
>   *           evaluating the branch.
>   *
> 


-- 
~Randy

<Prev in Thread] Current Thread [Next in Thread>