linux-mips
[Top] [All Lists]

[PATCH 2/2] MIPS: Remove a warning when PHYS_OFFSET is 0x0

To: unlisted-recipients:; (no To-header on input)
Subject: [PATCH 2/2] MIPS: Remove a warning when PHYS_OFFSET is 0x0
From: Mathieu Malaterre <malat@debian.org>
Date: Tue, 26 Dec 2017 12:37:14 +0100
Cc: Mathieu Malaterre <malat@debian.org>, Ralf Baechle <ralf@linux-mips.org>, Marcin Nowakowski <marcin.nowakowski@mips.com>, Miodrag Dinic <miodrag.dinic@mips.com>, James Hogan <jhogan@kernel.org>, Aleksandar Markovic <aleksandar.markovic@mips.com>, David Daney <david.daney@cavium.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lMUjSCsBMZt6tufLhTREbXkugsgOoaWz8c5niYjdD5Q=; b=W56vd8yWPu17X6EK5bfHVYSbUsJ7XnkBwTOTXhT8BdU+1PMZv8je7OEAQQ46lUJg6Z BIPgI9oRDpwmypj9zw9jLsF9ISPIzUKOwnOCl1QH2B3LMkVb+TDRF2WSeR6GJpxeNzIH n2C1ofh8U6Bk5IG3tg2+nY//gdvRNjJSu7duurv6L4kIM4AmL0vXN2MeXOKS2jO6bVZ0 a4UiWd1Zyw7CslUeS3Q95z2eyUCz6WOD81+YBeOGgFdPw6j/ERIF0wwEbYKq9qxiXJLX 3MqhIVph0QdbzdpLs3atfAdvKbLSdHUjbs7QIeI2uz2Bo4ju3pkOSq4HhyWJSoZ/N9IJ xXKQ==
In-reply-to: <20171226113717.15074-1-malat@debian.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20171226113717.15074-1-malat@debian.org>
Sender: linux-mips-bounce@linux-mips.org
Rewrite the comparison in `else if` statement, case where `min_low_pfn >
ARCH_PFN_OFFSET` has already been checked in the first `if` statement:

  if (min_low_pfn > ARCH_PFN_OFFSET) {

Fix non-fatal warning:

arch/mips/kernel/setup.c: In function ‘bootmem_init’:
arch/mips/kernel/setup.c:461:25: warning: comparison of unsigned expression < 0 
is always false [-Wtype-limits]
  } else if (min_low_pfn < ARCH_PFN_OFFSET) {
                         ^

Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
 arch/mips/kernel/setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index f19d61224c71..073695ccc1aa 100644
--- a/arch/mips/kernel/setup.c
+++ b/arch/mips/kernel/setup.c
@@ -458,7 +458,7 @@ static void __init bootmem_init(void)
                pr_info("Wasting %lu bytes for tracking %lu unused pages\n",
                        (min_low_pfn - ARCH_PFN_OFFSET) * sizeof(struct page),
                        min_low_pfn - ARCH_PFN_OFFSET);
-       } else if (min_low_pfn < ARCH_PFN_OFFSET) {
+       } else if (ARCH_PFN_OFFSET - min_low_pfn > 0UL) {
                pr_info("%lu free pages won't be used\n",
                        ARCH_PFN_OFFSET - min_low_pfn);
        }
-- 
2.11.0


<Prev in Thread] Current Thread [Next in Thread>