linux-mips
[Top] [All Lists]

Re: [PATCH v5 1/5] MIPS: Lonngson64: Copy kernel command line from arcs_

To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH v5 1/5] MIPS: Lonngson64: Copy kernel command line from arcs_cmdline
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 20 Dec 2017 17:36:16 +0100
Cc: James Hogan <jhogan@kernel.org>, linux-mips@linux-mips.org, Huacai Chan <chenhc@lemote.com>, linux-kernel@vger.kernel.org
In-reply-to: <20171216145751.3486-2-jiaxun.yang@flygoat.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20171216145751.3486-1-jiaxun.yang@flygoat.com> <20171216145751.3486-2-jiaxun.yang@flygoat.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.9.1 (2017-09-22)
On Sat, Dec 16, 2017 at 10:57:47PM +0800, Jiaxun Yang wrote:

> Since lemote-2f/marchtype.c need to get cmdline from loongson.h
> this patch simply copy kernel command line from arcs_cmdline
> to fix that issue

Sorry, I don't quite understand.

Is the issue that arcs_cmdline[] is declared as __initdata in
arch/mips/kernel/setup.c?

Note that it's ok to use arcs_cmdline on a non-ARCS machine.  ARC systems
were the first systems supported by Linux/MIPS, that's how the variable
got its name; the name was just never properly cleaned up but probably
should.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>