linux-mips
[Top] [All Lists]

Re: [PATCH v2 11/13] MIPS: mscc: add ocelot PCB123 device tree

To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH v2 11/13] MIPS: mscc: add ocelot PCB123 device tree
From: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Date: Mon, 18 Dec 2017 18:59:51 +0530
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, open list <linux-kernel@vger.kernel.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=NKEDsI0b4IXuW7v/QYd3Cky/hS7NTL1LBLv0GXodNwg=; b=gMhbnk7i/+T1wNBl/KyjidKfOdZIIeP/p2pKYgY+oGEalrDUZ6y/xqcydqB4MxbIwV F3PdDPwsMNZ9t8p3c8Kvge7MuzyJKDG23bPn7i3f5kmG5gRYXSS2HkAI7bPJEy6GqHvu cvJ1/YkXLJ/ZqG8FNXpoYE+v/wtJOJckMhy1xO5YUFw3irSRAfFcos1Md3kuuKXQKeFO 2HG8o9rofIuoXcHj89MR1bhI40jWYOFjwr8vq+BGdqVJtadBXZKpk8Jru0v9rp+vY5Bt OY/HGZH8zc8ZOUs5deqIIobDFfMHVzRHZ6Y1cfPkF1uMaGSOUvu9VyAY8FrFAj4Sikxl uRlw==
In-reply-to: <20171208154618.20105-12-alexandre.belloni@free-electrons.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20171208154618.20105-1-alexandre.belloni@free-electrons.com> <20171208154618.20105-12-alexandre.belloni@free-electrons.com>
Sender: linux-mips-bounce@linux-mips.org
On 8 December 2017 at 21:16, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> Add a device tree for the Microsemi Ocelot PCB123 evaluation board.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>  arch/mips/boot/dts/mscc/Makefile          |  2 ++
>  arch/mips/boot/dts/mscc/ocelot_pcb123.dts | 27 +++++++++++++++++++++++++++
>  2 files changed, 29 insertions(+)
>  create mode 100644 arch/mips/boot/dts/mscc/ocelot_pcb123.dts
>
> diff --git a/arch/mips/boot/dts/mscc/Makefile 
> b/arch/mips/boot/dts/mscc/Makefile
> index f0a155a74e02..09a1c4b97de2 100644
> --- a/arch/mips/boot/dts/mscc/Makefile
> +++ b/arch/mips/boot/dts/mscc/Makefile
> @@ -1,3 +1,5 @@
> +dtb-$(CONFIG_MSCC_OCELOT)      += ocelot_pcb123.dtb
> +
>  obj-y                          += $(patsubst %.dtb, %.dtb.o, $(dtb-y))
>
>  # Force kbuild to make empty built-in.o if necessary
> diff --git a/arch/mips/boot/dts/mscc/ocelot_pcb123.dts 
> b/arch/mips/boot/dts/mscc/ocelot_pcb123.dts
> new file mode 100644
> index 000000000000..42bd404471f6
> --- /dev/null
> +++ b/arch/mips/boot/dts/mscc/ocelot_pcb123.dts
> @@ -0,0 +1,27 @@
> +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
> +/* Copyright (c) 2017 Microsemi Corporation */
> +
> +/dts-v1/;
> +
> +#include "ocelot.dtsi"
> +
> +/ {
> +       compatible = "mscc,ocelot-pcb123", "mscc,ocelot";
> +
> +       chosen {
> +               stdout-path = "serial0:115200n8";
> +       };
> +
> +       memory {
> +               device_type = "memory";
> +               reg = <0x0 0x0e000000>;
> +       };
> +};
> +
> +&uart0 {
> +       status = "okay";
> +};
> +
> +&uart2 {
> +       status = "okay";
> +};
> --
> 2.15.1
>
>

Looks good to me.
Reviewed-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>

Regards,
PrasannaKumar

<Prev in Thread] Current Thread [Next in Thread>