linux-mips
[Top] [All Lists]

[PATCH 3/4] bcm63xx_enet: remove pointless mac_id check

To: netdev@vger.kernel.org, linux-mips@linux-mips.org
Subject: [PATCH 3/4] bcm63xx_enet: remove pointless mac_id check
From: Jonas Gorski <jonas.gorski@gmail.com>
Date: Sun, 17 Dec 2017 17:02:54 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, "David S. Miller" <davem@davemloft.net>, Florian Fainelli <f.fainelli@gmail.com>, bcm-kernel-feedback-list@broadcom.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cHKOb+MRH5zMX2KgeF7i9ex4zIEEdtfK1Zx4hI8sW+c=; b=c1CMEIBQXkmw1zQnyQpXdnXUN7XEoj6rqVrB7mF6JkB1OxVby32HaNn7OHT2mW1vmE BNxS2Xx2tbb5UdDtBBCqyVi1H90FtRUF81LVHrfK2a+Iyc2ZYx/ufCzk/5yuPK65osCO BuHWRJyviBbJvfbSTL98RKyDhqFgh87zpHl15WEYjzydI9nOLia4KPgKhjXbvSCkRr5e MJWjhV99bueiJGGXUec9vAaRMb3giuyRW4PiwvhxUU8x3It/ko8Nola8zU/q6/t606ID L/EP4WXotc7QIaTBS7bm8VQMIQWCHPGnOXq/PYpuYmOWnP7b4vmdEVxN+atQurOdrMSs gyfQ==
In-reply-to: <20171217160255.30342-1-jonas.gorski@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20171217160255.30342-1-jonas.gorski@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
Enabling the ephy clock for mac 1 is harmless, and the actual usage of
the ephy is not restricted to mac 0, so we might as well remove the
check.

Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
---
 drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c 
b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index e603a6fe6349..d4519c621d08 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -1787,7 +1787,7 @@ static int bcm_enet_probe(struct platform_device *pdev)
                priv->tx_chan = pd->tx_chan;
        }
 
-       if (priv->mac_id == 0 && priv->has_phy && !priv->use_external_mii) {
+       if (priv->has_phy && !priv->use_external_mii) {
                /* using internal PHY, enable clock */
                priv->phy_clk = devm_clk_get(&pdev->dev, "ephy");
                if (IS_ERR(priv->phy_clk)) {
-- 
2.13.2


<Prev in Thread] Current Thread [Next in Thread>