linux-mips
[Top] [All Lists]

Re: [PATCH v5 3/5] MIPS: Loongson64: Yeeloong add platform driver

To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH v5 3/5] MIPS: Loongson64: Yeeloong add platform driver
From: Philippe Ombredanne <pombredanne@nexb.com>
Date: Sat, 16 Dec 2017 19:28:40 +0100
Cc: James Hogan <jhogan@kernel.org>, Ralf Baechle <ralf@linux-mips.org>, Linux MIPS <linux-mips@linux-mips.org>, Huacai Chan <chenhc@lemote.com>, LKML <linux-kernel@vger.kernel.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=eSau6KrxQSQTTmhi/R3bLmRgcljlDucyhDQf1MdKWJo=; b=E9rM6xszUJGNwfp3q+5RMK2LECpzR9mxZZgW6x8HnqS+AwvGc4kuXm9xfvJUwwGp9W LszJhm2G/uAGJVyyKoPI+5dXAXNtbpqKr6nk91SsSy0KN+n9iKHagO19edZbD8PY4U67 WqQgVYMnejH7t9Eq2BaoQS/7yFBifa6Ur51WhMFlf1JmgE5asJFZSIhpSPllEOoIF5Gv DDvaJYKS5Io/MzFUxIGuk8L1AUetRJJfrJeVdj1VwlbLhqY4ciUA0oU5WjFnDrWcvN7o TZaqwkwAOI6IKw1c/cf1rVcC20W3WI3IewEUYr8gcJRSu3hg4RUOb5PXS1smvv1I3now mKLw==
In-reply-to: <20171216145751.3486-4-jiaxun.yang@flygoat.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20171216145751.3486-1-jiaxun.yang@flygoat.com> <20171216145751.3486-4-jiaxun.yang@flygoat.com>
Sender: linux-mips-bounce@linux-mips.org
Dear Jiaxun,

On Sat, Dec 16, 2017 at 3:57 PM, Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> Yeeloong is a laptop with a MIPS Loongson 2F processor, AMD CS5536
> chipset, and KB3310B controller.

<snip>

> --- /dev/null
> +++ b/drivers/platform/mips/yeeloong_laptop.c
> @@ -0,0 +1,1142 @@
> +/*
> + * Driver for YeeLoong laptop extras
> + *
> + *  Copyright (C) 2017 Jiaxun Yang.
> + *  Author: Jiaxun Yang <jiaxun.yang@flygoat.com>
> + *
> + *  Copyright (C) 2009 Lemote Inc.
> + *  Author: Wu Zhangjin <wuzhangjin@gmail.com>, Liu Junliang 
> <liujl@lemote.com>
> + *
> + *  Fixes: Petr Pisar <petr.pisar@atlas.cz>, 2012, 2013, 2014, 2015.
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License version 2 as
> + *  published by the Free Software Foundation.
> + */

Would you mind using the new SPDX tags here. See Thomas patches [1]

> +MODULE_LICENSE("GPL");

Also please make sure your module license (here GPL 2.0 or later per
module.h) matches your top level license tag  correctly (here GPL 2.0
only)?

[1] https://lkml.org/lkml/2017/12/4/934

-- 
Cordially
Philippe Ombredanne

<Prev in Thread] Current Thread [Next in Thread>