Re: [PATCH v3 14/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu

To:	Christoffer Dall <christoffer.dall@linaro.org>, Cornelia Huck <cohuck@redhat.com>
Subject:	Re: [PATCH v3 14/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl
From:	Paolo Bonzini <pbonzini@redhat.com>
Date:	Tue, 12 Dec 2017 17:47:21 +0100
Cc:	Christoffer Dall <cdall@kernel.org>, Christian Borntraeger <borntraeger@de.ibm.com>, kvm@vger.kernel.org, Andrew Jones <drjones@redhat.com>, Radim Krčmář <rkrcmar@redhat.com>, Marc Zyngier <marc.zyngier@arm.com>, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, James Hogan <jhogan@kernel.org>, linux-mips@linux-mips.org, Paul Mackerras <paulus@ozlabs.org>, kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1tZhXIdBiK+/A9SzT0dCj8/InryiDXoncXLPhbikw4E=; b=s7HG9HhUA2LT5plZLYIPLZkle5W+xPhnII2pIRvCPv/RywAiNM47ZzUcGAv5dt+9zI gYi8HzjOoN5jU739mKQ+IoFLxJMMCMGOKaAJf0G7/bM07gGfygaN0n7c/3hxB4aSxVdP YB9lqdutjYa289gblIj1LMlfRxAnVHvIPIylBr+eVFprGFM7OYD5ycQHK3srTIVN1Fhb zKmo4G8vKw8Q7pYjMKY/WPFwzPoKNG1q+khxhCXACRL/dv1qLrIT845taOcUY5/hkpdb yDD2pYrjo1nP448Z0BgIaJeZKH/XRU65FETWkB9oiTAz8mV+he7Xjc/bmsmay3VRz64S JRbw==
In-reply-to:	<20171211152226.GJ910@cbox>
List-archive:	<http://www.linux-mips.org/archives/linux-mips/>
List-help:	<mailto:ecartis@linux-mips.org?Subject=help>
List-id:	linux-mips <linux-mips.eddie.linux-mips.org>
List-owner:	<mailto:ralf@linux-mips.org>
List-post:	<mailto:linux-mips@linux-mips.org>
List-software:	Ecartis version 1.0.0
List-subscribe:	<mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe:	<mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient:	rfc822;linux-mips@linux-mips.org
References:	<20171204203538.8370-1-cdall@kernel.org> <20171204203538.8370-15-cdall@kernel.org> <20171211141241.2129a84c.cohuck@redhat.com> <20171211152226.GJ910@cbox>
Sender:	linux-mips-bounce@linux-mips.org
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 11/12/2017 16:22, Christoffer Dall wrote: > I find the special casing with the immediate return a bit ugly. Maybe > introduce a helper async_vcpu_ioctl() or so that sets -ENOIOCTLCMD in > its default case and return here if ret != -ENOIOCTLCMD? Christian, > what do you think? I'll post my attempt at it shortly. Thanks, Paolo

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH v3 11/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl_set_guest_debug, (continued) Re: [PATCH v3 11/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl_set_guest_debug, Cornelia Huck Re: [PATCH v3 11/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl_set_guest_debug, Christoffer Dall Re: [PATCH v3 11/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl_set_guest_debug, Paolo Bonzini [PATCH v3 12/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl_get_fpu, Christoffer Dall Re: [PATCH v3 12/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl_get_fpu, Cornelia Huck [PATCH v3 13/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl_set_fpu, Christoffer Dall Re: [PATCH v3 13/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl_set_fpu, Cornelia Huck [PATCH v3 14/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl, Christoffer Dall Re: [PATCH v3 14/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl, Cornelia Huck Re: [PATCH v3 14/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl, Christoffer Dall Re: [PATCH v3 14/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl, Paolo Bonzini <= [PATCH v3 15/16] KVM: arm/arm64: Avoid vcpu_load for other vcpu ioctls than KVM_RUN, Christoffer Dall [PATCH v3 16/16] KVM: arm/arm64: Move vcpu_load call after kvm_vcpu_first_run_init, Christoffer Dall

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:	Re: [PATCH v3 11/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl_set_guest_debug, Paolo Bonzini
Next by Date:	Re: [PATCH v2 0/6] MIPS: NT_PRFPREG regset handling fixes, Ralf Baechle
Previous by Thread:	Re: [PATCH v3 14/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl, Christoffer Dall
Next by Thread:	[PATCH v3 15/16] KVM: arm/arm64: Avoid vcpu_load for other vcpu ioctls than KVM_RUN, Christoffer Dall
Indexes:	[Date] [Thread] [Top] [All Lists]

Previous by Date:

Re: [PATCH v3 11/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl_set_guest_debug, Paolo Bonzini

Next by Date:

Re: [PATCH v2 0/6] MIPS: NT_PRFPREG regset handling fixes, Ralf Baechle

Previous by Thread:

Re: [PATCH v3 14/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl, Christoffer Dall

Next by Thread:

[PATCH v3 15/16] KVM: arm/arm64: Avoid vcpu_load for other vcpu ioctls than KVM_RUN, Christoffer Dall

Indexes:

[Date] [Thread] [Top] [All Lists]