[Top] [All Lists]

Re: [PATCH] TC: Delete an error message for a failed memory allocation i

To: "Maciej W. Rozycki" <>,
Subject: Re: [PATCH] TC: Delete an error message for a failed memory allocation in tc_bus_add_devices()
From: SF Markus Elfring <>
Date: Mon, 11 Dec 2017 14:38:52 +0100
Cc: Joe Perches <>, Ralf Bächle <>, LKML <>,
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <> <> <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
>  However I would indeed prefer that a commit description is at least 
> exhaustive enough for such a dumb reviewer as I am to understand what is 
> going on right away.

I can follow your desire in principle.

> So please make it say at least:
> "Remove an extraneous message that duplicates the diagnostic already 
> provided by `kzalloc' for a memory allocation failure in this function."

How much clarification can such a wording bring to the software situation
if the desired data structures might be still unclear for “the diagnostic”?

> or suchlike in v2 for me to apply a Reviewed-by: tag.

Are you interested in a safe description for a default Linux allocation
failure report?

How do you think about corresponding reference documentation
(besides source code)?


<Prev in Thread] Current Thread [Next in Thread>