[Top] [All Lists]

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

To: Philippe Ombredanne <>, Greg Kroah-Hartman <>
Subject: Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.
From: David Daney <>
Date: Fri, 1 Dec 2017 12:01:02 -0800
Authentication-results: spf=none (sender IP is );
Cc: Carlos Munoz <>, David Daney <>,,,, "David S. Miller" <>, Rob Herring <>, Mark Rutland <>,, LKML <>, "Steven J. Hill" <>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <>, Andrew Lunn <>, Florian Fainelli <>, James Hogan <>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=bPbOflf0oNMmxCINO80cu58rpJ8M7fsfE5+F9Xl/u4A=; b=FJwOxvMlU9jGrnX5/mgofR/SYtu4TXSse/HWXJhBsNy5aGrUSuVGuNz4LoEU65KqeuSpzKc/ai20Ib61FzVO9bPGfxyzje4uHTqh03odfB8QXgcHAzevmoY0Oy/fSbtc/QmOv8w8KRwqWka95GqX/g8Epp8h55YjPanVuVlaCUs=
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <> <> <> <> <>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
On 12/01/2017 11:49 AM, Philippe Ombredanne wrote:
David, Greg,

On Fri, Dec 1, 2017 at 6:42 PM, David Daney <> wrote:
On 11/30/2017 11:53 PM, Philippe Ombredanne wrote:
--- /dev/null
+++ b/arch/mips/cavium-octeon/resource-mgr.c
@@ -0,0 +1,371 @@
+// SPDX-License-Identifier: GPL-2.0
+ * Resource manager for Octeon.
+ *
+ * This file is subject to the terms and conditions of the GNU General
+ * License.  See the file "COPYING" in the main directory of this
+ * for more details.
+ *
+ * Copyright (C) 2017 Cavium, Inc.
+ */

Since you nicely included an SPDX id, you would not need the
boilerplate anymore. e.g. these can go alright?

They may not be strictly speaking necessary, but I don't think they hurt
anything.  Unless there is a requirement to strip out the license text, we
would stick with it as is.

I think the requirement is there and that would be much better for
everyone: keeping both is redundant and does not bring any value, does
it? Instead it kinda removes the benefits of having the SPDX id in the
first place IMHO.

Furthermore, as there have been already ~12K+ files cleaned up and
still over 60K files to go, it would really nice if new files could
adopt the new style: this way we will not have to revisit and repatch
them in the future.

I am happy to follow any style Greg would suggest. There doesn't seem to be much documentation about how this should be done yet.

David Daney

<Prev in Thread] Current Thread [Next in Thread>