linux-mips
[Top] [All Lists]

Re: [PATCH 4.4 04/35] MIPS: Update defconfigs for NF_CT_PROTO_DCCP/UDPLI

To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 4.4 04/35] MIPS: Update defconfigs for NF_CT_PROTO_DCCP/UDPLITE change
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 20 Mar 2017 11:42:39 +0100
Cc: Ben Hutchings <ben@decadent.org.uk>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, stable@vger.kernel.org, linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=eEWplzz35GyjVDpVuYCkajz1OJjc811aV7mAQGgl21c=; b=VNMF45//1eYXgvdwYpT5EQ42MKf4ajGrRVXGgiHwtvkmNEGUIEZRFBFoOLD4waomf7 uQDhHCc9otQ92wuOKM3k87Yx3mNVnRysMxkVil+KXEIfNrFpCOjpmNUoJQKVrL+Tr1dn SYQr9CYzDpGoJyS/ta8UmDryQ2Lh1KZzVGrVFziuXCAmEpQ5A/EvZP4378Q/PQpS/M0r odDBzarZyX7wXTiKuPrNmb5nkgJ1oshIrC7hF3euEIuzLFLfHIDQD1xrSfa/6+aHDn3K jguUMcL3nc9ommKLwvNcqh3A1nrhRhHAgeh2zlnWc7qdxYi73Nz6Q/LBi+rUBoV+g6iv Bveg==
In-reply-to: <20170320103052.GB3047@kroah.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20170316142906.685052998@linuxfoundation.org> <20170316142906.994447562@linuxfoundation.org> <1489939516.2852.71.camel@decadent.org.uk> <20170320103052.GB3047@kroah.com>
Sender: linux-mips-bounce@linux-mips.org
On Mon, Mar 20, 2017 at 11:30 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Sun, Mar 19, 2017 at 04:05:16PM +0000, Ben Hutchings wrote:
>> On Thu, 2017-03-16 at 23:29 +0900, Greg Kroah-Hartman wrote:
>> > 4.4-stable review patch.  If anyone has any objections, please let me know.
>> >
>> > ------------------
>> >
>> > From: Arnd Bergmann <arnd@arndb.de>
>> >
>> > commit 9ddc16ad8e0bc7742fc96d5aaabc5b8698512cd1 upstream.
>> >
>> > In linux-4.10-rc, NF_CT_PROTO_UDPLITE and NF_CT_PROTO_DCCP are bool
>> > symbols instead of tristate, and kernelci.org reports a bunch of
>> > warnings for this, like:
>> >
>> > arch/mips/configs/malta_kvm_guest_defconfig:63:warning: symbol value 'm' 
>> > invalid for NF_CT_PROTO_UDPLITE
>> > arch/mips/configs/malta_defconfig:62:warning: symbol value 'm' invalid for 
>> > NF_CT_PROTO_DCCP
>> > arch/mips/configs/malta_defconfig:63:warning: symbol value 'm' invalid for 
>> > NF_CT_PROTO_UDPLITE
>> > arch/mips/configs/ip22_defconfig:70:warning: symbol value 'm' invalid for 
>> > NF_CT_PROTO_DCCP
>> > arch/mips/configs/ip22_defconfig:71:warning: symbol value 'm' invalid for 
>> > NF_CT_PROTO_UDPLITE
>> >
>> > This changes all the MIPS defconfigs with these symbols to have them
>> > built-in.
>> >
>> > Fixes: 9b91c96c5d1f ("netfilter: conntrack: built-in support for UDPlite")
>> > Fixes: c51d39010a1b ("netfilter: conntrack: built-in support for DCCP")
>> [...]
>>
>> I don't think this was needed for 4.4 or 4.9, as those symbols were
>> still tristate type.
>
> I don't know, Arnd was the one that reported it to me.
>
> Arnd?

I thought I had only reported it for the v4.10-stable tree. I was a bit vague
about which of the ones I reported were needed on older trees as well,
but the changelog text is fairly specific.

      Arnd

<Prev in Thread] Current Thread [Next in Thread>