linux-mips
[Top] [All Lists]

Re: [PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is

To: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>, "rmk+kernel@armlinux.org.uk" <rmk+kernel@armlinux.org.uk>, "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>, "target-devel@vger.kernel.org" <target-devel@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
Date: Tue, 31 Jan 2017 19:32:10 +0000
Accept-language: nl-NL, en-US
Authentication-results: spf=pass (sender IP is 74.221.232.54) smtp.mailfrom=sandisk.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=bestguesspass action=none header.from=sandisk.com;
Cc: "davem@davemloft.net" <davem@davemloft.net>, "f.fainelli@gmail.com" <f.fainelli@gmail.com>, "nab@linux-iscsi.org" <nab@linux-iscsi.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandiskcorp.onmicrosoft.com; s=selector1-sandisk-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fn7OQvbaMbLlF6Hw8sufMBIIMXYva9Qd4wYVY+DRA+c=; b=lafeimHWequ1xIjCMtpaR7c2vosUztuzc8kPs1QrwpuCgDpPRqI3LHuy4ByyrEcocc6rfH4jtRzcQojpShhnlAnfsAwXxZ40M9Gjxf3DCBo/X2vV656GiyvnbD3cpYXrYNfshR3a6a5gj4FfwJUpFCwbBBRhjq71jpUi+6rxj2c=
In-reply-to: <E1cYdxN-0000Wr-AS@rmk-PC.armlinux.org.uk>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20170131191704.GA8281@n2100.armlinux.org.uk> <E1cYdxN-0000Wr-AS@rmk-PC.armlinux.org.uk>
Sender: linux-mips-bounce@linux-mips.org
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99
Thread-index: AQHSe/i3nY2j/fx3D0CIhHO4QnfypA==
Thread-topic: [PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h
On Tue, 2017-01-31 at 19:19 +0000, Russell King wrote:
> drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration 
> of function 'try_module_get' [-Werror=implicit-function-declaration]
> 
> Add linux/module.h to iscsi_target_login.c.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>  drivers/target/iscsi/iscsi_target_login.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/target/iscsi/iscsi_target_login.c 
> b/drivers/target/iscsi/iscsi_target_login.c
> index 450f51deb2a2..eab274d17b5c 100644
> --- a/drivers/target/iscsi/iscsi_target_login.c
> +++ b/drivers/target/iscsi/iscsi_target_login.c
> @@ -17,6 +17,7 @@
>   
> ******************************************************************************/
>  
>  #include <crypto/hash.h>
> +#include <linux/module.h>
>  #include <linux/string.h>
>  #include <linux/kthread.h>
>  #include <linux/idr.h>

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
<Prev in Thread] Current Thread [Next in Thread>