linux-mips
[Top] [All Lists]

Re: [PATCH V7 1/3] MIPS: Rearrange PTE bits into fixed positions.

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH V7 1/3] MIPS: Rearrange PTE bits into fixed positions.
From: "Steven J. Hill" <Steven.Hill@imgtec.com>
Date: Fri, 27 Feb 2015 13:04:48 -0600
Cc: <linux-mips@linux-mips.org>
In-reply-to: <54F0AECF.5070501@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1424996199-21366-1-git-send-email-Steven.Hill@imgtec.com> <1424996199-21366-2-git-send-email-Steven.Hill@imgtec.com> <54EFBF9D.4020004@gmail.com> <54EFE6B9.1050109@imgtec.com> <54F0AECF.5070501@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
On 02/27/2015 11:52 AM, David Daney wrote:
> 
> I think there is still misunderstanding.
> 
> Your patches leave us with definitions for *both* _PAGE_READ *and* 
> _PAGE_NO_READ defined in the source code.  My suggestion was to 
> eliminate all vestiges of _PAGE_READ and _PAGE_READ_SHIFT, and unify
> all variants to use _PAGE_NO_READ
> 
Okay, I see what you are after. I think it is worth doing, but I would
really like to get XPA into 4.0 along with this patch as it is. I will
commit to doing a follow up patch for the above. Is that acceptable?

<Prev in Thread] Current Thread [Next in Thread>