linux-mips
[Top] [All Lists]

[PATCH] loongson-3/hpet.c: remove IRQF_DISABLED flag

To: ralf@linux-mips.org, taohl@lemote.com, chenhc@lemote.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: [PATCH] loongson-3/hpet.c: remove IRQF_DISABLED flag
From: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
Date: Fri, 27 Feb 2015 13:14:22 +0100
Cc: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
The IRQF_DISABLED is a NOOP and scheduled to be removed.  According to Ingo
Molnar (e58aa3d2d0cc01ad8d6f7f640a0670433f794922) running IRQ handlers with
interrupts enabled can cause stack overflows when the interrupt line of the
issuing device is still active.

Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
---
 arch/mips/loongson/loongson-3/hpet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/loongson/loongson-3/hpet.c 
b/arch/mips/loongson/loongson-3/hpet.c
index e898d68..5c21cd3 100644
--- a/arch/mips/loongson/loongson-3/hpet.c
+++ b/arch/mips/loongson/loongson-3/hpet.c
@@ -162,7 +162,7 @@ static irqreturn_t hpet_irq_handler(int irq, void *data)
 
 static struct irqaction hpet_irq = {
        .handler = hpet_irq_handler,
-       .flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_TIMER,
+       .flags = IRQF_NOBALANCING | IRQF_TIMER,
        .name = "hpet",
 };
 
-- 
1.9.1


<Prev in Thread] Current Thread [Next in Thread>