linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: mark prom_free_prom_memory() everywhere with __init

To: Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH] MIPS: mark prom_free_prom_memory() everywhere with __init
From: David Daney <ddaney.cavm@gmail.com>
Date: Wed, 25 Feb 2015 15:36:46 -0800
Cc: Ralf Baechle <ralf@linux-mips.org>, David Daney <david.daney@cavium.com>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=8XZErQbZPQNZjXCTMdOVb2xcSUCQIq4wFQiT8NxjwwM=; b=iAaogRU2fZrtohCOLR4P7ICDp4yEURxYWHEubuiveHe71HSjJ8RvT2bE8IjJpSOaed edvsyMlQqWXd6ZG7Vb+FBa9gQMZDxzKFOIKOs4X8yhTC+5yNAfQigcQl1maOhUxD5+hu msK3ygdVfJn+2WZMebTSlkJE+b8JgTSIepmE/RwIBP3aa5K50LzR4RoWJQf5G4g66F4s y0YM9ZRxW1ZJLDlbGObCDIqwyWkOi+ZAtJMw0VL+pmlUbz33wH61kVo+KS0KEM93XWIs fTJrMG9r6qy5tstE3MH9SZ+PbMDmMUamtfF3tZu/c0iT6DS3Wk01wge3T296vVCQpvzo r6cg==
In-reply-to: <1424907064-31621-1-git-send-email-aaro.koskinen@iki.fi>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1424907064-31621-1-git-send-email-aaro.koskinen@iki.fi>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
On 02/25/2015 03:31 PM, Aaro Koskinen wrote:
Mark prom_free_prom_memory with() everywhere with __init.

On OCTEON the function is non-trivial and we can potentially even
save some memory.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>

OCTEON part:

Acked-by: David Daney <david.daney@cavium.com>

---
  arch/mips/cavium-octeon/setup.c  | 2 +-
  arch/mips/lantiq/prom.c          | 2 +-
  arch/mips/mti-sead3/sead3-init.c | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/mips/cavium-octeon/setup.c b/arch/mips/cavium-octeon/setup.c
index a42110e..d0fa0bc 100644
--- a/arch/mips/cavium-octeon/setup.c
+++ b/arch/mips/cavium-octeon/setup.c
@@ -1043,7 +1043,7 @@ int prom_putchar(char c)
  }
  EXPORT_SYMBOL(prom_putchar);

-void prom_free_prom_memory(void)
+void __init prom_free_prom_memory(void)
  {
        if (CAVIUM_OCTEON_DCACHE_PREFETCH_WAR) {
                /* Check for presence of Core-14449 fix.  */
diff --git a/arch/mips/lantiq/prom.c b/arch/mips/lantiq/prom.c
index 39ab3e7..0db099e 100644
--- a/arch/mips/lantiq/prom.c
+++ b/arch/mips/lantiq/prom.c
@@ -41,7 +41,7 @@ int ltq_soc_type(void)
        return soc_info.type;
  }

-void prom_free_prom_memory(void)
+void __init prom_free_prom_memory(void)
  {
  }

diff --git a/arch/mips/mti-sead3/sead3-init.c b/arch/mips/mti-sead3/sead3-init.c
index bfbd17b..3572ea3 100644
--- a/arch/mips/mti-sead3/sead3-init.c
+++ b/arch/mips/mti-sead3/sead3-init.c
@@ -147,6 +147,6 @@ void __init prom_init(void)
  #endif
  }

-void prom_free_prom_memory(void)
+void __init prom_free_prom_memory(void)
  {
  }



<Prev in Thread] Current Thread [Next in Thread>