linux-mips
[Top] [All Lists]

[PATCH v2 4/4] MIPS: LLVMLinux: Silence variable self-assignment warning

To: unlisted-recipients:; (no To-header on input)
Subject: [PATCH v2 4/4] MIPS: LLVMLinux: Silence variable self-assignment warnings.
From: Daniel Sanders <daniel.sanders@imgtec.com>
Date: Tue, 24 Feb 2015 15:25:11 +0000
Cc: Toma Tabacu <toma.tabacu@imgtec.com>, Daniel Sanders <daniel.sanders@imgtec.com>, Ralf Baechle <ralf@linux-mips.org>, <linux-mips@linux-mips.org>, <linux-kernel@vger.kernel.org>
In-reply-to: <1424791511-11407-1-git-send-email-daniel.sanders@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1424791511-11407-1-git-send-email-daniel.sanders@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
From: Toma Tabacu <toma.tabacu@imgtec.com>

Remove variable self-assignments.
This silences a bunch of -Wself-assign warnings reported by clang.
The changed code can be compiled without warnings by both gcc and clang.

Signed-off-by: Toma Tabacu <toma.tabacu@imgtec.com>
Signed-off-by: Daniel Sanders <daniel.sanders@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
---
v2 refreshes the patch.

 arch/mips/math-emu/dp_add.c | 5 -----
 arch/mips/math-emu/dp_sub.c | 5 -----
 arch/mips/math-emu/sp_add.c | 5 -----
 arch/mips/math-emu/sp_sub.c | 5 -----
 4 files changed, 20 deletions(-)

diff --git a/arch/mips/math-emu/dp_add.c b/arch/mips/math-emu/dp_add.c
index 7f64577..58b2795 100644
--- a/arch/mips/math-emu/dp_add.c
+++ b/arch/mips/math-emu/dp_add.c
@@ -150,8 +150,6 @@ union ieee754dp ieee754dp_add(union ieee754dp x, union 
ieee754dp y)
                 * leaving result in xm, xs and xe.
                 */
                xm = xm + ym;
-               xe = xe;
-               xs = xs;
 
                if (xm >> (DP_FBITS + 1 + 3)) { /* carry out */
                        xm = XDPSRS1(xm);
@@ -160,11 +158,8 @@ union ieee754dp ieee754dp_add(union ieee754dp x, union 
ieee754dp y)
        } else {
                if (xm >= ym) {
                        xm = xm - ym;
-                       xe = xe;
-                       xs = xs;
                } else {
                        xm = ym - xm;
-                       xe = xe;
                        xs = ys;
                }
                if (xm == 0)
diff --git a/arch/mips/math-emu/dp_sub.c b/arch/mips/math-emu/dp_sub.c
index 7a17402..2eb87cd2 100644
--- a/arch/mips/math-emu/dp_sub.c
+++ b/arch/mips/math-emu/dp_sub.c
@@ -153,8 +153,6 @@ union ieee754dp ieee754dp_sub(union ieee754dp x, union 
ieee754dp y)
                /* generate 28 bit result of adding two 27 bit numbers
                 */
                xm = xm + ym;
-               xe = xe;
-               xs = xs;
 
                if (xm >> (DP_FBITS + 1 + 3)) { /* carry out */
                        xm = XDPSRS1(xm);       /* shift preserving sticky */
@@ -163,11 +161,8 @@ union ieee754dp ieee754dp_sub(union ieee754dp x, union 
ieee754dp y)
        } else {
                if (xm >= ym) {
                        xm = xm - ym;
-                       xe = xe;
-                       xs = xs;
                } else {
                        xm = ym - xm;
-                       xe = xe;
                        xs = ys;
                }
                if (xm == 0) {
diff --git a/arch/mips/math-emu/sp_add.c b/arch/mips/math-emu/sp_add.c
index 2d84d46..7a33af4 100644
--- a/arch/mips/math-emu/sp_add.c
+++ b/arch/mips/math-emu/sp_add.c
@@ -148,8 +148,6 @@ union ieee754sp ieee754sp_add(union ieee754sp x, union 
ieee754sp y)
                 * leaving result in xm, xs and xe.
                 */
                xm = xm + ym;
-               xe = xe;
-               xs = xs;
 
                if (xm >> (SP_FBITS + 1 + 3)) { /* carry out */
                        SPXSRSX1();
@@ -157,11 +155,8 @@ union ieee754sp ieee754sp_add(union ieee754sp x, union 
ieee754sp y)
        } else {
                if (xm >= ym) {
                        xm = xm - ym;
-                       xe = xe;
-                       xs = xs;
                } else {
                        xm = ym - xm;
-                       xe = xe;
                        xs = ys;
                }
                if (xm == 0)
diff --git a/arch/mips/math-emu/sp_sub.c b/arch/mips/math-emu/sp_sub.c
index 8592e49..1189bc5 100644
--- a/arch/mips/math-emu/sp_sub.c
+++ b/arch/mips/math-emu/sp_sub.c
@@ -148,8 +148,6 @@ union ieee754sp ieee754sp_sub(union ieee754sp x, union 
ieee754sp y)
                /* generate 28 bit result of adding two 27 bit numbers
                 */
                xm = xm + ym;
-               xe = xe;
-               xs = xs;
 
                if (xm >> (SP_FBITS + 1 + 3)) { /* carry out */
                        SPXSRSX1();     /* shift preserving sticky */
@@ -157,11 +155,8 @@ union ieee754sp ieee754sp_sub(union ieee754sp x, union 
ieee754sp y)
        } else {
                if (xm >= ym) {
                        xm = xm - ym;
-                       xe = xe;
-                       xs = xs;
                } else {
                        xm = ym - xm;
-                       xe = xe;
                        xs = ys;
                }
                if (xm == 0) {
-- 
2.1.4


<Prev in Thread] Current Thread [Next in Thread>