[Top] [All Lists]

Re: [PATCH] Revert "MIPS: mm: tlbex: Use cpu_has_mips_r2_exec_hazard for

To: David Daney <>
Subject: Re: [PATCH] Revert "MIPS: mm: tlbex: Use cpu_has_mips_r2_exec_hazard for the EHB instruction"
From: "Maciej W. Rozycki" <>
Date: Tue, 24 Feb 2015 01:10:58 +0000 (GMT)
Cc:,,, Leonid Yegoshin <>, Markos Chandras <>, David Daney <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <>
User-agent: Alpine 2.11 (LFD 23 2013-08-11)
On Mon, 23 Feb 2015, David Daney wrote:

> From: David Daney <>
> This reverts commit 77f3ee59ee7cfe19e0ee48d9a990c7967fbfcbed.
> There are two problems:
> 1) It breaks OCTEON, which will now crash in early boot with:
>   Kernel panic - not syncing: No TLB refill handler yet (CPU type: 80)
> 2) The logic is broken.
> The meaning of cpu_has_mips_r2_exec_hazard is that the EHB instruction
> is required.  The offending patch attempts (and fails) to change the
> meaning to be that EHB is part of the ISA.
> Signed-off-by: David Daney <>
> ---

 Code affected will have to be reconsidered including possibly older 
changes as well.  Meanwhile, to revert the immediate regression, you have 

Reviewed-by: Maciej W. Rozycki <>

Next time please try to use the imperative mood for the commit message 
though, as per Documentation/SubmittingPatches.

 Overall I think it makes sense to have a look back there every once in a 
while to avoid getting trapped in routine.  Some breakage we fall into 
from time to time results from missing the guidelines set there, sigh.


<Prev in Thread] Current Thread [Next in Thread>