linux-mips
[Top] [All Lists]

Re: [PATCH] arch: mips: kvm: Enable after disabling interrupt

To: Tapasweni Pathak <tapaswenipathak@gmail.com>
Subject: Re: [PATCH] arch: mips: kvm: Enable after disabling interrupt
From: James Hogan <james.hogan@imgtec.com>
Date: Mon, 23 Feb 2015 14:07:17 +0000
Cc: <gleb@kernel.org>, <pbonzini@redhat.com>, <ralf@linux-mips.org>, <kvm@vger.kernel.org>, <linux-mips@linux-mips.org>, <linux-kernel@vger.kernel.org>, <julia.lawall@lip6.fr>
In-reply-to: <20150222161821.GA6980@kt-Inspiron-3542>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20150222161821.GA6980@kt-Inspiron-3542>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.22 (2013-10-16)
On Sun, Feb 22, 2015 at 09:48:21PM +0530, Tapasweni Pathak wrote:
> Enable disabled interrupt, on unsuccessful operation.
> 
> Found by Coccinelle.
> 
> Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Reviewed-by: James Hogan <james.hogan@imgtec.com>

Cheers
James

> ---
>  arch/mips/kvm/tlb.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/kvm/tlb.c b/arch/mips/kvm/tlb.c
> index bbcd822..b6beb0e 100644
> --- a/arch/mips/kvm/tlb.c
> +++ b/arch/mips/kvm/tlb.c
> @@ -216,6 +216,7 @@ int kvm_mips_host_tlb_write(struct kvm_vcpu *vcpu, 
> unsigned long entryhi,
>       if (idx > current_cpu_data.tlbsize) {
>               kvm_err("%s: Invalid Index: %d\n", __func__, idx);
>               kvm_mips_dump_host_tlbs();
> +             local_irq_restore(flags);
>               return -1;
>       }
> 
> --
> 1.7.9.5
> 
> 

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>