linux-mips
[Top] [All Lists]

Re: [Xen-devel] [PATCH v4] modify the IO_TLB_SEGSIZE and IO_TLB_DEFAULT_

To: "Wang Xiaoming" <xiaoming.wang@intel.com>
Subject: Re: [Xen-devel] [PATCH v4] modify the IO_TLB_SEGSIZE and IO_TLB_DEFAULT_SIZE configurable as flexible requirement about SW-IOMMU.
From: "Jan Beulich" <JBeulich@suse.com>
Date: Tue, 17 Feb 2015 10:08:48 +0000
Cc: <chris@chris-wilson.co.uk>, <david.vrabel@citrix.com>, <lauraa@codeaurora.org>, <heiko.carstens@de.ibm.com>, <linux@horizon.com>, "Chuansheng Liu" <chuansheng.liu@intel.com>, "Zhang Dongxing" <dongxing.zhang@intel.com>, <takahiro.akashi@linaro.org>, <akpm@linux-foundation.org>, <linux-mips@linux-mips.org>, <ralf@linux-mips.org>, <xen-devel@lists.xenproject.org>, <boris.ostrovsky@oracle.com>, <konrad.wilk@oracle.com>, <d.kasatkin@samsung.com>, <pebolle@tiscali.nl>, <linux-kernel@vger.kernel.org>
Envelope-id: groupwise.54E31330.215:78:76fe:N
In-reply-to: <1424155903-4262-1-git-send-email-xiaoming.wang@intel.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;groupwise-linux-mips@linux-mips.org:9:1
References: <1424155903-4262-1-git-send-email-xiaoming.wang@intel.com>
Sender: linux-mips-bounce@linux-mips.org
>>> On 17.02.15 at 07:51, <xiaoming.wang@intel.com> wrote:
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -3438,10 +3438,12 @@ bytes respectively. Such letter suffixes can also be 
> entirely omitted.
>                       it if 0 is given (See Documentation/cgroups/memory.txt)
>  
>       swiotlb=        [ARM,IA-64,PPC,MIPS,X86]
> -                     Format: { <int> | force }
> +                     Format: { <int> | force | <int> | <int>}
>                       <int> -- Number of I/O TLB slabs
>                       force -- force using of bounce buffers even if they
>                                wouldn't be automatically used by the kernel
> +                     <int> -- Maximum allowable number of contiguous slabs 
> to map
> +                     <int> -- The size of SW-MMU mapped.

This makes no sense - the new numbers added aren't position
independent (nor were the previous <int> and "force").

Also you are (supposedly) removing all uses of
IO_TLB_DEFAULT_SIZE, yet you don't seem to remove the
definition itself.

Finally - are arbitrary numbers really okay for the newly added
command line options? I.e. shouldn't you add some checking of
their validity?

Jan


<Prev in Thread] Current Thread [Next in Thread>