linux-mips
[Top] [All Lists]

Re: MIPS: CONFIG_MIPS_R6?

To: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
Subject: Re: MIPS: CONFIG_MIPS_R6?
From: Paul Bolle <pebolle@tiscali.nl>
Date: Mon, 16 Feb 2015 09:39:32 +0100
Cc: Valentin Rothberg <valentinrothberg@gmail.com>, Markos Chandras <markos.chandras@imgtec.com>, Ralf Baechle <ralf@linux-mips.org>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, LKML <linux-kernel@vger.kernel.org>
In-reply-to: <54DFF4EE.6010008@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1423934469.9418.18.camel@x220> <54DFF4EE.6010008@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
Leonid,

On Sat, 2015-02-14 at 17:22 -0800, Leonid Yegoshin wrote:
> On 02/14/2015 09:21 AM, Paul Bolle wrote:
> > Your commits 430857eae56c ("MIPS: mm: Add MIPS R6 instruction
> > encodings") and 90163242784b ("MIPS: kernel: unaligned: Add support for
> > the MIPS R6") are included in yesterday's linux-next (ie,
> > next-20150213). I noticed because a script I use to check linux-next
> > spotted a problem with it.
> >
> > These commits added three references to CONFIG_MIPS_R6, were probably
> > CONFIG_CPU_MIPSR6 was intended. One reference is in a comment, which
> > should be trivial to get fixed. The other two references are in
> > (negative) preprocessor checks. It's not certain, at least not to me,
> > how these should be fixed.
> >
> >
> > Paul Bolle
> 
> Yes, please.

The obvious fix (ie, three times s/CONFIG_MIPS_R6/CONFIG_CPU_MIPSR6/)
isn't trivial and requires run time testing, which I have no idea how to
do, sorry.


Paul Bolle


<Prev in Thread] Current Thread [Next in Thread>