linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: mm: Remove dead macro definitions

To: Andreas Ruprecht <rupran@einserver.de>
Subject: Re: [PATCH] MIPS: mm: Remove dead macro definitions
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Fri, 13 Feb 2015 19:50:18 +0000 (GMT)
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Valentin Rothberg <valentinrothberg@gmail.com>, Paul Bolle <pebolle@tiscali.nl>
In-reply-to: <1423748572-31012-1-git-send-email-rupran@einserver.de>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1423748572-31012-1-git-send-email-rupran@einserver.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.11 (LFD 23 2013-08-11)
On Thu, 12 Feb 2015, Andreas Ruprecht wrote:

> In commit c441d4a54c6e ("MIPS: mm: Only build one microassembler that
> is suitable"), the Makefile at arch/mips/mm was rewritten to only
> build the "right" microassembler file, depending on whether
> CONFIG_CPU_MICROMIPS is set or not.
> 
> In the files, however, there are still preprocessor definitions
> depending on CONFIG_CPU_MICROMIPS. The #ifdef around them can now
> never evaluate to true, so let's remove them altogether.
> 
> This inconsistency was found using the undertaker-checkpatch tool.
> 
> Signed-off-by: Andreas Ruprecht <rupran@einserver.de>
> ---

Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org>

 Thanks for catching it!

  Maciej

<Prev in Thread] Current Thread [Next in Thread>