[Top] [All Lists]

RE: mips: Re-introduce copy_user_page

To: Leonid Yegoshin <>, Guenter Roeck <>, Ralf Baechle <>
Subject: RE: mips: Re-introduce copy_user_page
From: "Wilcox, Matthew R" <>
Date: Wed, 4 Feb 2015 16:25:08 +0000
Accept-language: en-CA, en-US
Cc: "" <>, "" <>, Atsushi Nemoto <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <>
Thread-index: AQHQP+Dc9wfYcGSMQU6+AGJBA2rhxpzfTD2w
Thread-topic: mips: Re-introduce copy_user_page
There is no 'struct page' for the source of this data.  We have a kernel 
address for it; that's all.

-----Original Message-----
From: Leonid Yegoshin [] 
Sent: Tuesday, February 03, 2015 10:40 AM
To: Guenter Roeck; Ralf Baechle
Cc:;; Atsushi Nemoto; 
Wilcox, Matthew R
Subject: Re: mips: Re-introduce copy_user_page

On 01/30/2015 09:23 PM, Guenter Roeck wrote:
> Commit bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") replaced
> the inline function copy_user_page for mips with an external reference,
> but neglected to introduce the actual non-inline function. Restore it.
> Fixes: bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork")
> Fixes: 4927b7d77c00 ("dax,ext2: replace the XIP page fault handler with the 
> DAX page fault handler")
> Cc: Atsushi Nemoto <>
> Cc: Matthew Wilcox <>
> Signed-off-by: Guenter Roeck <>

Why do you use copy_user_page?
It doesn't work properly in HIGHMEM environment and it is excluded from 
MIPS because of that, I believe.

You should use copy_user_highpage() for user pages.

- Leonid.

<Prev in Thread] Current Thread [Next in Thread>