linux-mips
[Top] [All Lists]

Re: mips: Re-introduce copy_user_page

To: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: mips: Re-introduce copy_user_page
From: Guenter Roeck <linux@roeck-us.net>
Date: Tue, 03 Feb 2015 19:33:02 -0800
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Atsushi Nemoto <anemo@mba.ocn.ne.jp>, Matthew Wilcox <matthew.r.wilcox@intel.com>
Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=aFlBWjcla1Qje7J+quqoMfzBFJg9uOsHMAQN33p1zX8=; b=gaS7Sf5XEUP9uvIegSFvuwnV2QAQORsPmLOPXvWwZXekn2gdZHA7P5yhZmCmamC9dOtKnubdrxVh3esfJh267ugcAgPYbjsfnjiVqtiE3cP2Rzx03cKFC58BNBktPgO11nPrYk0bZdWlJGQ56P2Ot47Az45hqz8EpTswSK7WYYA=;
In-reply-to: <54D11608.2070408@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1422681807-28395-1-git-send-email-linux@roeck-us.net> <54D11608.2070408@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
On 02/03/2015 10:40 AM, Leonid Yegoshin wrote:
On 01/30/2015 09:23 PM, Guenter Roeck wrote:
Commit bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") replaced
the inline function copy_user_page for mips with an external reference,
but neglected to introduce the actual non-inline function. Restore it.

Fixes: bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork")
Fixes: 4927b7d77c00 ("dax,ext2: replace the XIP page fault handler with the DAX page 
fault handler")
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>


Why do you use copy_user_page?
It doesn't work properly in HIGHMEM environment and it is excluded from MIPS 
because of that, I believe.

You should use copy_user_highpage() for user pages.


Then maybe mips should not declare it the function external, the commit log
of the patch removing it should have mentioned that and why it was removed,
and there should be a clear statement somewhere stating that copy_user_page
shall not be used. I don't find such a statement anywhere in the kernel.

Guenter


<Prev in Thread] Current Thread [Next in Thread>