[Top] [All Lists]

Re: mips: Re-introduce copy_user_page

To: Guenter Roeck <>, Ralf Baechle <>
Subject: Re: mips: Re-introduce copy_user_page
From: Leonid Yegoshin <>
Date: Tue, 3 Feb 2015 10:40:08 -0800
Cc: <>, <>, "Atsushi Nemoto" <>, Matthew Wilcox <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
On 01/30/2015 09:23 PM, Guenter Roeck wrote:
Commit bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") replaced
the inline function copy_user_page for mips with an external reference,
but neglected to introduce the actual non-inline function. Restore it.

Fixes: bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork")
Fixes: 4927b7d77c00 ("dax,ext2: replace the XIP page fault handler with the DAX page 
fault handler")
Cc: Atsushi Nemoto <>
Cc: Matthew Wilcox <>
Signed-off-by: Guenter Roeck <>

Why do you use copy_user_page?
It doesn't work properly in HIGHMEM environment and it is excluded from MIPS because of that, I believe.

You should use copy_user_highpage() for user pages.

- Leonid.

<Prev in Thread] Current Thread [Next in Thread>