linux-mips
[Top] [All Lists]

Re: [PATCH 26/36] serial: 8250_jz47xx: support for Ingenic jz47xx UARTs

To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
Subject: Re: [PATCH 26/36] serial: 8250_jz47xx: support for Ingenic jz47xx UARTs
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Mon, 2 Feb 2015 08:32:32 -0800
Cc: Paul Burton <paul.burton@imgtec.com>, linux-mips@linux-mips.org, Lars-Peter Clausen <lars@metafoo.de>, linux-serial@vger.kernel.org
In-reply-to: <54CFA5BC.2070103@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1421620067-23933-1-git-send-email-paul.burton@imgtec.com> <1421620881-25136-1-git-send-email-paul.burton@imgtec.com> <20150130233105.GA10564@kroah.com> <54CFA5BC.2070103@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.23 (2014-03-12)
On Mon, Feb 02, 2015 at 04:28:44PM +0000, Zubair Lutfullah Kakakhel wrote:
> Hi Greg,
> 
> On 30/01/15 23:31, Greg Kroah-Hartman wrote:
> > On Sun, Jan 18, 2015 at 02:41:21PM -0800, Paul Burton wrote:
> >> Introduce a driver suitable for use with the UARTs present in
> >> Ingenic jz47xx series SoCs. These are described as being ns16550
> >> compatible but aren't quite - they require the setting of an extra bit
> >> in the FCR register to enable the UART module. The serial_out
> >> implementation is the same as that in arch/mips/jz4740/serial.c - which
> >> will shortly be removed.
> >>
> >> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> Cc: Lars-Peter Clausen <lars@metafoo.de>
> >> Cc: linux-serial@vger.kernel.org
> >> ---
> >>  drivers/tty/serial/8250/8250_jz47xx.c | 228 
> >> ++++++++++++++++++++++++++++++++++
> >>  drivers/tty/serial/8250/Kconfig       |   8 ++
> >>  drivers/tty/serial/8250/Makefile      |   1 +
> >>  3 files changed, 237 insertions(+)
> >>  create mode 100644 drivers/tty/serial/8250/8250_jz47xx.c
> > 
> > This patch blows up on x86 systems, breaking the build :(
> 
> Ouch.
> 
> Did you compile after all the patches applied? Or after every single patch.

After every individual patch, like is required :)

> I can't manage to reproduce the build error with all of them applied.

Try it with just this one patch applied.

thanks,

greg k-h

<Prev in Thread] Current Thread [Next in Thread>