[Top] [All Lists]

Re: [PATCH] mips: n32: use compat getsockopt syscall

To: Sorin Dumitru <>, <>, <>
Subject: Re: [PATCH] mips: n32: use compat getsockopt syscall
From: James Hogan <>
Date: Fri, 20 Jun 2014 11:50:39 +0100
Cc: <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <> <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0
On 20/06/14 11:40, Sorin Dumitru wrote:
> On 06/20/14 12:54, James Hogan wrote:
>> On 20/06/14 08:53, Sorin Dumitru wrote:
>>> Signed-off-by: Sorin Dumitru <>
>> A little more commit message wouldn't hurt. Did it break a particular
>> program?
> Yes, it was found by an internal program trying to get IP_PKTOPTIONS on
> a cavium octeon board.
> Should I resubmit stating what was broken in the commit message?

Yeh, if you don't mind. I think it's useful to know exactly why a change
was made and what it fixes when later digging through the git history
(e.g. commit 515c7af85ed9 is a great example of that).


<Prev in Thread] Current Thread [Next in Thread>