[Top] [All Lists]

Re: [PATCH 1/4] MIPS: BCM47XX: add Belkin F7Dxxxx board detection

To: Cody P Schafer <>
Subject: Re: [PATCH 1/4] MIPS: BCM47XX: add Belkin F7Dxxxx board detection
From: Rafał Miłecki <>
Date: Fri, 3 Jan 2014 07:43:32 +0100
Cc: Hauke Mehrtens <>, Ralf Baechle <>,, "" <>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=KUapxzlAKcIPdxIbBaDDgkl5y5e7CTMJkqzWANaKx+M=; b=XDXII2Oq4smnt5MENuXEri8uxDNvwiLF7W56eCHQ6YuwofO0uc4uRphXNwG6WRryc3 IHL5C2qocYcMdgJoUnaUg3tSHwtW03cCHkU42HFX1LmR0FW88p+VnnJpLEf/G41zb1Zz Spt/8j2GCHV4OFJQghLpG3dpglugCSI9HApy8akSJ0Gjd0ydLOwKzpzSeePjGe84TpT4 qkdQyM79lkD8E6srQN2M2KLq6KY5jGFi/SZlOrFRIAKttRjENhPFbKKkIczvejA1ZUt3 h1sJQgLJGKmW+Y2ia1Nx/pLBPoEyWaeDT4833+JGmFk9u6mcGvx7TM80+pYWedMdMKuh IX3w==
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <> <> <>
2014/1/3 Rafał Miłecki <>:
> 2014/1/2 Cody P Schafer <>:
>> On Thu, Jan 2, 2014 at 1:35 PM, Rafał Miłecki <> wrote:
>>> 2014/1/2 Hauke Mehrtens <>:
>>>> From: Cody P Schafer <>
>>>> Add a few Belkin F7Dxxxx entries, with F7D4401 sourced from online
>>>> documentation and the "F7D7302" being observed. F7D3301, F7D3302, and
>>>> F7D4302 are reasonable guesses which are unlikely to cause
>>>> mis-detection.
>>>> It also appears that at least the F7D3302, F7D3301, F7D7301, and F7D7302
>>>> have a shared boardtype and boardrev, so use that as a fallback to a
>>>> "generic" F7Dxxxx board.
>>> Cody, Hauke: I'm starring at this patch for 10 minutes now and it's
>>> still unclear for me.
>>> You say 3301, 3302, 7301 and 7302 have the same board_* entries
>>> stating they can be treated with a generic ID entry.
>> I included the generic BCM47XX_BOARD_BELKIN_F7DXXXX entry to catch
>> those boards that we don't yet have specific entries for. It allows us
>> to get the leds and buttons working mostly correctly.
>> The specific names are included so that one can determine a more exact
>> board. The stock CFE requires different images for different boards
>> even though they are very similar. Hardware variations are simply
>> gigabit vs 100MB switches, usb port population, led population, and
>> 5Ghz radio population (none of which truly require the greater detail
>> in board type).
> OK, maybe this is sth I'm missing... Why we should care about CFE in
> kernel? We don't talk with CFE, do we? So we don't have to know which
> device's CFE is that.

Also: are the CFEs in 3302 and 7302 identical? Because you use
BCM47XX_BOARD_BELKIN_F7D3302 for both of them.

I'd prefer to see BCM47XX_BOARD_BELKIN_F7DX302, or maybe even better:
two separated entries that can be combined in leds.c and buttons.c.


<Prev in Thread] Current Thread [Next in Thread>