[Top] [All Lists]

Re: [PATCH v2] mips/include/asm/mipsregs.h: include linux/types.h

To: Qais Yousef <>
Subject: Re: [PATCH v2] mips/include/asm/mipsregs.h: include linux/types.h
From: David Daney <>
Date: Mon, 09 Dec 2013 10:48:45 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=3eN/YZxGeaeMmxxXPNGJ5zmN+I7TIZ+41m0Vkvgx3SM=; b=LNzlIdMQtjk58M+wrmLn+PISYRJEAiG0lovWETec86YrszMc7XLknvE87T+f0Pzs4I u6g9tr6Xu86O+Jv6HHZh2OTorfv96JGnhNA1UeZs4lKoDp0JJ93H7iyHUfdaCfJbEfOe EE+pZcTJAk/q56LljS+M6GSb14c9q1BVFs6smepZTFUY+AxU2LI4tiEVf/qIgtXyQrcQ 4nmki9fk6kY7i4utxovNGHLiHEYv1LOYMk2hAJ5WQTsik5ogdhuxngmdDwXUiPXWMIfg /A034v51McHo2qajSDb9gs5kMVmoLUv8fy/96o7BFXeoY8OOO36EuFrTfve22e3layDe LiZQ==
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
On 12/09/2013 01:49 AM, Qais Yousef wrote:
The file uses u16 type but doesn't include its definition explicitly

I was getting this error when including this header in my driver:

   arch/mips/include/asm/mipsregs.h:644:33: error: unknown type name ‘u16’

Signed-off-by: Qais Yousef <>
Reviewed-by: Steven J. Hill <>

Acked-by: David Daney <>

changes since v1:
        - include linux/types.h instead of s/u16/unsigned short/
        - amend commit message accordingly

  arch/mips/include/asm/mipsregs.h |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/mips/include/asm/mipsregs.h b/arch/mips/include/asm/mipsregs.h
index e033141..86479bb 100644
--- a/arch/mips/include/asm/mipsregs.h
+++ b/arch/mips/include/asm/mipsregs.h
@@ -14,6 +14,7 @@
  #define _ASM_MIPSREGS_H

  #include <linux/linkage.h>
+#include <linux/types.h>
  #include <asm/hazards.h>
  #include <asm/war.h>

<Prev in Thread] Current Thread [Next in Thread>