[Top] [All Lists]

Re: [PATCH 5/5] spi: add bcm63xx HSSPI driver

To: Mark Brown <>
Subject: Re: [PATCH 5/5] spi: add bcm63xx HSSPI driver
From: Jonas Gorski <>
Date: Wed, 4 Dec 2013 15:28:25 +0100
Cc: MIPS Mailing List <>,, Ralf Baechle <>, John Crispin <>, Florian Fainelli <>, Kevin Cernekee <>, Maxime Bizon <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <> <> <> <>
On Wed, Dec 4, 2013 at 3:08 PM, Mark Brown <> wrote:
> On Wed, Dec 04, 2013 at 03:04:48PM +0100, Jonas Gorski wrote:
>> On Wed, Dec 4, 2013 at 2:38 PM, Mark Brown <> wrote:
>> > This ought to be disable_unprepare().  It would also be better to move
>> > this to runtime PM (you can set auto_runtime_pm to have the core manage
>> > the enable and disable for you) since that will save a bit of power.
>> I already set auto_runtime_pm to true. I basically copied what's
>> currently in spi-bcm63xx.c *coughs*. Is there anything else needed
>> besides what you mentioned?
> You'll need to call pm_runtime_enable() and so on to turn on runtime PM
> in probe() and reverse that in remove() but otherwise no, just adding
> the runtime callbacks should be fine.

I see. Looks like I just copied your oversight from
5355d96d6fb56507761f261a23c0831f67fa0e0f ("spi/bcm63xx: Convert to
core runtime PM") :P I'll add that to my list of things to fix.

Grepping through drivers/spi, I see a few drivers not calling
pm_runtime_enable(), but setting auto_runtime_pm to true, and a few
doing the opposite. These should probably aligned, too.


<Prev in Thread] Current Thread [Next in Thread>