[Top] [All Lists]

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

To: Alexander Gordeev <>,
Subject: Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern
From: Mark Lord <>
Date: Tue, 08 Oct 2013 21:55:26 -0400
Cc: Bjorn Helgaas <>, Ralf Baechle <>, Michael Ellerman <>, Benjamin Herrenschmidt <>, Martin Schwidefsky <>, Ingo Molnar <>, Tejun Heo <>, Dan Williams <>, Andy King <>, Jon Mason <>, Matt Porter <>,,,,,,,,,,,,,, Solarflare linux maintainers <>,, "Inc." <>,, Linus Torvalds <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0
On 13-10-02 06:29 AM, Alexander Gordeev wrote:
> This update converts pci_enable_msix() and pci_enable_msi_block()
> interfaces to canonical kernel functions and makes them return a
> error code in case of failure or 0 in case of success.

Rather than silently break dozens of drivers in mysterious ways,
please invent new function names for the replacements to the
existing pci_enable_msix() and pci_enable_msi_block() functions.

That way, both in-tree and out-of-tree drivers will notice the API change,
rather than having it go unseen and just failing for unknown reasons.


<Prev in Thread] Current Thread [Next in Thread>