[Top] [All Lists]

Re: [PATCH] MIPS: SmartMIPS: Fix build

To: Thierry Reding <>, Ralf Baechle <>
Subject: Re: [PATCH] MIPS: SmartMIPS: Fix build
From: Markos Chandras <>
Date: Mon, 7 Oct 2013 16:29:07 +0100
Cc: <>, <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0
On 10/07/13 16:10, Thierry Reding wrote:
All CONFIG_CPU_HAS_SMARTMIPS #ifdefs have been removed from code, but
the ACX register declaration in struct pt_regs is still protected by it,
causing builds to fail. Remove the #ifdef protection and always declare
the register.

Signed-off-by: Thierry Reding <>
  arch/mips/include/asm/ptrace.h | 2 --
  1 file changed, 2 deletions(-)

diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
index 7bba9da..d47bdce 100644
--- a/arch/mips/include/asm/ptrace.h
+++ b/arch/mips/include/asm/ptrace.h
@@ -33,9 +33,7 @@ struct pt_regs {
        unsigned long cp0_status;
        unsigned long hi;
        unsigned long lo;
        unsigned long acx;
        unsigned long cp0_badvaddr;
        unsigned long cp0_cause;
        unsigned long cp0_epc;

Hi Thierry,

Looks good to me. Thanks!

Reviewed-by: Markos Chandras <>

<Prev in Thread] Current Thread [Next in Thread>