[Top] [All Lists]

Re: [PATCH RFC 46/77] mlx4: Update MSI/MSI-X interrupts enablement code

To: Alexander Gordeev <>
Subject: Re: [PATCH RFC 46/77] mlx4: Update MSI/MSI-X interrupts enablement code
From: Jack Morgenstein <>
Date: Thu, 3 Oct 2013 11:39:32 +0300
Cc:, Bjorn Helgaas <>, Ralf Baechle <>, Michael Ellerman <>, Benjamin Herrenschmidt <>, Martin Schwidefsky <>, Ingo Molnar <>, Tejun Heo <>, Dan Williams <>, Andy King <>, Jon Mason <>, Matt Porter <>,,,,,,,,,,,,,, Solarflare linux maintainers <>, "VMware, Inc." <>,,,
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Organization: Mellanox
Original-recipient: rfc822;
References: <> <>
On Wed,  2 Oct 2013 12:49:02 +0200
Alexander Gordeev <> wrote:

> As result of recent re-design of the MSI/MSI-X interrupts enabling
> pattern this driver has to be updated to use the new technique to
> obtain a optimal number of MSI/MSI-X interrupts required.
> Signed-off-by: Alexander Gordeev <>

New review -- ACK (i.e., patch is OK), subject to acceptance of patches
05 and 07 of this patch set.

I sent my previous review (NACK) when I was not yet aware that
changes proposed were due to the two earlier patches (mentioned above)
in the current patch set.

The change log here should actually read something like the following:

As a result of changes to the MSI/MSI_X enabling procedures, this driver
must be modified in order to preserve its current msi/msi_x enablement


<Prev in Thread] Current Thread [Next in Thread>