[Top] [All Lists]

Re: [PATCH 2/2] framebuffer: Remove pmag-aa-fb

To: Geert Uytterhoeven <>
Subject: Re: [PATCH 2/2] framebuffer: Remove pmag-aa-fb
From: "Maciej W. Rozycki" <>
Date: Sun, 22 Sep 2013 22:54:54 +0100 (BST)
Cc: Joe Perches <>, Jean-Christophe Plagniol-Villard <>, Tomi Valkeinen <>, Linux Fbdev development list <>, "" <>, Linux MIPS Mailing List <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <> <> <> <1379702587.2301.12.camel@joe-AO722> <> <>
User-agent: Alpine 2.03 (LFD 1266 2009-07-14)
On Sun, 22 Sep 2013, Geert Uytterhoeven wrote:

> >  Thanks, but the changes required are actually much more than that -- the
> > driver has never been converted to the modern TURBOchannel API.  I have
> > now dug out an old patch I was working on back in 2006 to convert this
> > driver as well as drivers/video/maxinefb.c.  I'll try to complete the two
> > drivers as soon as possible (unfortunately I can't test the latter at all;
> > it's for an onboard graphics adapter of another DECstation model),
> > although I now remember the main reason I didn't complete them back then
> > was they used an old internal API that was removed and no suitable
> > replacement provided.  I need to investigate again what that actually was
> > though (hw cursor probably).
> pmag-aa-fb.c still has struct display_switch (for the old drawing API) and the
> old fb_ops (with get_var()/get_fix()), instead of the new fb_ops (rectangular
> drawing API and var/fix as member data).

 That I got covered already in the old patch, but there was something 
else.  Otherwise I would have pushed it along updates for pmag-ba-fb.c and 
pmagb-b-fb.c long ago.


<Prev in Thread] Current Thread [Next in Thread>