[Top] [All Lists]

Re: [MIPS] CP0 PRId and CP1 FPIR register access masks

To: Ralf Baechle <>
Subject: Re: [MIPS] CP0 PRId and CP1 FPIR register access masks
From: "Maciej W. Rozycki" <>
Date: Tue, 17 Sep 2013 17:59:09 +0100 (BST)
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <>
User-agent: Alpine 2.03 (LFD 1266 2009-07-14)
On Tue, 17 Sep 2013, Ralf Baechle wrote:

> But while it's cleaner, I think the idiom read_c0_prid() & some_MASK is
> so common that maybe something like
>   #define read_c0_prid_imp()  (read_c0_prid() & PRID_IMP_MASK)
>   #define read_c0_prid_rev()  (read_c0_prid() & PRID_REV_MASK)
>   #define read_c0_prid_comp() (read_c0_prid() & PRID_COMP_MASK)
> should be introduced as a next step.

 In some places maybe.  Other need several parts of PRId examined and 
using these accessors would be a pessimisation (GCC cannot combine 
multiple read_c0_prid() calls into one).  Some further places should 
probably use current_cpu_data.processor_id instead.  Maybe even most 
should.  Overall I'm not sure how much use these macros would get after 


<Prev in Thread] Current Thread [Next in Thread>