[Top] [All Lists]

Re: [PATCH v2 4/4] clkdev: Fix race condition in clock lookup from

To: Sylwester Nawrocki <>
Subject: Re: [PATCH v2 4/4] clkdev: Fix race condition in clock lookup from device tree
From: Russell King - ARM Linux <>
Date: Tue, 20 Aug 2013 22:52:21 +0100
Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;; s=caramon; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=jJy1paQmsacpJomOTXi/c0KHIxiqE3avBlsrK3qRtW0=; b=HoNy5kHV5mPGkBsAcEYBh9uVcIXrkWlJlKOg9EzuhBV06EMudksTIgm5kWJ3hb2reElyveAojKt0irUdHg7pNe0F5VDXDLCT4BqELKGYVc5Hpgu3KD7LiEwJvrRk1WqEE03qB66h0bmDp8IpGo5e2+2h1TuaMw1OdDa/KFdu4g0=;
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <>
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Aug 20, 2013 at 07:34:23PM +0200, Sylwester Nawrocki wrote:
> There is currently a race condition in the device tree part of clk_get()
> function, since the pointer returned from of_clk_get_by_name() may become
> invalid before __clk_get() call. I.e. due to the clock provider driver
> remove() callback being called in between of_clk_get_by_name() and
> __clk_get().
> Fix this by doing both the look up and __clk_get() operations with the
> clock providers list mutex held. This ensures that the clock pointer
> returned from __of_clk_get_from_provider() call and passed to __clk_get()
> is valid, as long as the clock supplier module first removes its clock
> provider instance and then does clk_unregister() on the corresponding
> clocks.
> Signed-off-by: Sylwester Nawrocki <>
> Signed-off-by: Kyungmin Park <>
> Reviewed-by: Mike Turquette <>


Acked-by: Russell King <>

<Prev in Thread] Current Thread [Next in Thread>