[Top] [All Lists]

Re: [PATCHv4 02/11] pci: use weak functions for MSI arch-specific functi

To: Thomas Petazzoni <>
Subject: Re: [PATCHv4 02/11] pci: use weak functions for MSI arch-specific functions
From: Michael Ellerman <>
Date: Tue, 02 Jul 2013 10:53:16 +1000
Cc: Bjorn Helgaas <>,, Russell King <>, Grant Likely <>, Rob Herring <>, Thomas Gleixner <>, Jason Cooper <>, Andrew Lunn <>, Gregory Clement <>, Lior Amsalem <>,,, Heiko Carstens <>, Thierry Reding <>, Paul Mackerras <>, "H. Peter Anvin" <>,,,, Ingo Molnar <>, Ezequiel Garcia <>, Fenghua Yu <>, Chris Metcalf <>,, Tony Luck <>, Ralf Baechle <>, Maen Suleiman <>, Martin Schwidefsky <>,,, "David S. Miller" <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <>
On Mon, 2013-07-01 at 15:42 +0200, Thomas Petazzoni wrote:
> Until now, the MSI architecture-specific functions could be overloaded
> using a fairly complex set of #define and compile-time
> conditionals. In order to prepare for the introduction of the msi_chip
> infrastructure, it is desirable to switch all those functions to use
> the 'weak' mechanism. This commit converts all the architectures that
> were overidding those MSI functions to use the new strategy.

The MSI code used to use weak functions, until we discovered they were
being miscompiled on some toolchains (11df1f0). I assume these days
we're confident they work correctly.


<Prev in Thread] Current Thread [Next in Thread>