[Top] [All Lists]

Re: [PATCH] Revert "MIPS: make CAC_ADDR and UNCAC_ADDR account for PHYS_

To: "Steven J. Hill" <>
Subject: Re: [PATCH] Revert "MIPS: make CAC_ADDR and UNCAC_ADDR account for PHYS_OFFSET"
From: Sergei Shtylyov <>
Date: Thu, 20 Jun 2013 15:09:51 +0400
Cc:, Leonid Yegoshin <>,, Florian Fainelli <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <>
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6

On 20-06-2013 9:13, Steven J. Hill wrote:

From: Leonid Yegoshin <>

This reverts commit 3f4579252aa166641861a64f1c2883365ca126c2. It is
invalid because the macros CAC_ADDR and UNCAC_ADDR have a kernel
virtual address as an argument and also returns a kernel virtual
address. Using and physical address PHYS_OFFSET is blatantly wrong
for a macro common to multiple platforms.

Change-Id: I19feb1e537c6a517e6b42f3ec6ce746b6a97617e

    Same comment as on all Leonid's patches -- remove this line.

Signed-off-by: Leonid Yegoshin <>
Acked-by: Steven J. Hill <>

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>